Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid link #471

Merged

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jun 12, 2020

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I fixed some links which occur as dead links at the official website:

  • change absURL about source code path (not another document link)
  • change godoc domain

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi requested review from kevindiu and hlts2 June 12, 2020 03:11
@pull-assistant
Copy link

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     🐛 📝 fix link

Powered by Pull Assistant. Last update d16b663 ... d16b663. Read the comment docs.

@kevindiu
Copy link
Contributor

can you also fix this?
https://github.com/vdaas/vald/pull/471/files#diff-c414e3e4151a3294cd86a33ca60eb228R7

@vankichi
Copy link
Contributor Author

Sorry, I'm not sure what you mention.
Could you please tell me more detail?

@kevindiu
Copy link
Contributor

kevindiu commented Jun 12, 2020

Sorry seems github cannot jump to the code I pointed :(
On line 7, the Contribution guideline is pointing to a symbolic link. Is it correct?
https://github.com/vdaas/vald/blob/d16b6637d89cc589cb97abff22b532f7f1162118/docs/contributing/coding-style.md

@vankichi
Copy link
Contributor Author

arr ;(
Well, there is no problem what you mentioned.
The link under the docs dir will be overwritten when sync contents.
You can confirm at vdaas/web.

Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 8a608c7 into master Jun 12, 2020
@kpango kpango deleted the documentation/contributing/update-contributing-guide/fix-path branch June 12, 2020 08:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants