Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add use case document #482

Merged
merged 16 commits into from
Jul 6, 2020
Merged

Add use case document #482

merged 16 commits into from
Jul 6, 2020

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Jun 16, 2020 •
edited
Loading

Author review required?

Description:

This PR create the use case document to describe the general use case of Vald.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@kevindiu kevindiu requested a review from hlts2 June 16, 2020 10:19
@kevindiu kevindiu requested a review from datelier June 18, 2020 01:07
@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: documentation/usecase

hlts2
hlts2 requested changes Jun 22, 2020
View reviewed changes
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
docs/usecase/usage-example.md Outdated Show resolved Hide resolved
@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: documentation/usecase

@pull-assistant
Copy link

pull-assistant bot commented Jun 24, 2020 •
edited
Loading

Score: 0.49

Best reviewed: with all changes

Optimal code review plan (16 commits squashed)

add usecase document ... Apply suggestions fr...

Squashed 16 commits:

Powered by Pull Assistant. Last update 40bf93c ... c1a73f4. Read the comment docs.

@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: documentation/usecase

hlts2
hlts2 previously approved these changes Jun 24, 2020
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu kevindiu changed the title [draft] add use case document Add use case document Jun 24, 2020
@vankichi
Copy link
Contributor

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: documentation/usecase

@kevindiu kevindiu requested a review from vankichi June 24, 2020 08:41
vankichi
vankichi reviewed Jun 24, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hlts2
hlts2 previously approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi
vankichi previously approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented Jul 6, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: documentation/usecase

@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and hlts2 via c1a73f4 July 6, 2020 09:42
@github-actions github-actions bot added size/M and removed size/M labels Jul 6, 2020
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci approved these changes Jul 6, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 38995d0 into master Jul 6, 2020
@vankichi vankichi deleted the documentation/usecase branch July 6, 2020 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango left review comments

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@rinx rinx rinx left review comments

@vankichi vankichi vankichi left review comments

@hlts2 hlts2 hlts2 left review comments

@datelier datelier Awaiting requested review from datelier

@kmrmt kmrmt Awaiting requested review from kmrmt

Assignees
No one assigned
Labels
area/agent/core area/agent/sidecar area/helm area/internal priority/low size/XL team/set SET team type/documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@kevindiu @vdaas-ci @vankichi @rinx @kpango @hlts2