Added test case for `internal/errorgroup` #494

hlts2 · 2020-06-18T08:19:38Z

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I added a test case for internal/errorgroup.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.14.3
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.11.5

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

codecov · 2020-06-18T08:38:39Z

Codecov Report

Merging #494 into master will increase coverage by 0.34%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #494      +/-   ##
=========================================
+ Coverage    7.97%   8.32%   +0.34%     
=========================================
  Files         401     401              
  Lines       20705   20705              
=========================================
+ Hits         1651    1723      +72     
+ Misses      18812   18739      -73     
- Partials      242     243       +1

Impacted Files	Coverage Δ
internal/errgroup/group.go	`94.73% <0.00%> (+94.73%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1ad8de1...3662e95. Read the comment docs.

internal/errgroup/group_test.go

hlts2 · 2020-06-19T01:34:50Z

/rebase

vdaas-ci · 2020-06-19T01:35:25Z

[REBASE] Rebase triggered by hlts2 for branch: test/internal/errorgroup

internal/errgroup/group_test.go

pull-assistant · 2020-06-22T04:22:27Z

Best reviewed: commit by commit

Optimal code review plan (2 warnings)

feat: test case

fix: refactor

fix: goleak bug

Update internal/errgroup/group_test.go

fix: apply suggestion

go.sum 50% changes removed in fix: revert go.sum

fix: revert go.sum

fix: apply suggestion

go.sum 50% changes removed in fix: revert go.sum

fix: revert go.sum

fix: apply suggestion

Powered by Pull Assistant. Last update 3cd90b8 ... 3662e95. Read the comment docs.

hlts2 · 2020-06-22T04:22:35Z

/rebase

vdaas-ci · 2020-06-22T04:23:11Z

[REBASE] Rebase triggered by hlts2 for branch: test/internal/errorgroup

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

internal/errgroup/group_test.go

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

kevindiu

LGTM

vankichi

LGTM

vankichi · 2020-06-22T06:24:13Z

/rebase
/format
/approve

vdaas-ci · 2020-06-22T06:24:46Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/errorgroup

vdaas-ci · 2020-06-22T06:25:37Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

hlts2 requested a review from kevindiu June 18, 2020 08:19

hlts2 self-assigned this Jun 18, 2020

github-actions bot added area/internal team/set SET team size/XL type/test Adding tests priority/low labels Jun 18, 2020

kevindiu reviewed Jun 18, 2020

View reviewed changes

internal/errgroup/group_test.go Show resolved Hide resolved

kevindiu reviewed Jun 18, 2020

View reviewed changes

internal/errgroup/group_test.go Outdated Show resolved Hide resolved

vdaas-ci force-pushed the test/internal/errorgroup branch from db9325d to cc8a38c Compare June 19, 2020 01:35

kpango reviewed Jun 19, 2020

View reviewed changes

internal/errgroup/group_test.go Outdated Show resolved Hide resolved

kevindiu reviewed Jun 22, 2020

View reviewed changes

internal/errgroup/group_test.go Outdated Show resolved Hide resolved

internal/errgroup/group_test.go Outdated Show resolved Hide resolved

hlts2 and others added 5 commits June 22, 2020 04:23

feat: test case

3cd90b8

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: refactor

3caf60c

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: refactor

bdf32df

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: goleak bug

a5f93b5

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

Update internal/errgroup/group_test.go

693a1bf

Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>

vdaas-ci force-pushed the test/internal/errorgroup branch from 566784d to 693a1bf Compare June 22, 2020 04:23

hlts2 added 6 commits June 22, 2020 13:29

fix: apply suggestion

52afd43

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: revert go.sum

9b32cdc

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: revert go.sum

3713b75

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: apply suggestion

73e4d22

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: revert go.sum

2e5d15d

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: revert go.sum

ee5d1db

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

kevindiu reviewed Jun 22, 2020

View reviewed changes

internal/errgroup/group_test.go Outdated Show resolved Hide resolved

internal/errgroup/group_test.go Outdated Show resolved Hide resolved

internal/errgroup/group_test.go Outdated Show resolved Hide resolved

fix: apply suggestion

3662e95

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

kevindiu approved these changes Jun 22, 2020

View reviewed changes

vankichi approved these changes Jun 22, 2020

View reviewed changes

vdaas-ci approved these changes Jun 22, 2020

View reviewed changes

vankichi merged commit e8ce139 into master Jun 22, 2020

vankichi deleted the test/internal/errorgroup branch June 22, 2020 06:55

vdaas-ci mentioned this pull request Jun 25, 2020

[patch] Revise S3 reader/writer: compatible with IBM Cloud Object Storage #509

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added test case for `internal/errorgroup` #494

Added test case for `internal/errorgroup` #494

hlts2 commented Jun 18, 2020 •

edited

Loading

codecov bot commented Jun 18, 2020 •

edited

Loading

hlts2 commented Jun 19, 2020

vdaas-ci commented Jun 19, 2020

pull-assistant bot commented Jun 22, 2020 •

edited

Loading

hlts2 commented Jun 22, 2020

vdaas-ci commented Jun 22, 2020

kevindiu left a comment

vankichi left a comment

vankichi commented Jun 22, 2020

vdaas-ci commented Jun 22, 2020

vdaas-ci commented Jun 22, 2020

vdaas-ci left a comment

Added test case for internal/errorgroup #494

Added test case for internal/errorgroup #494

Conversation

hlts2 commented Jun 18, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

codecov bot commented Jun 18, 2020 • edited Loading

Codecov Report

hlts2 commented Jun 19, 2020

vdaas-ci commented Jun 19, 2020

pull-assistant bot commented Jun 22, 2020 • edited Loading

hlts2 commented Jun 22, 2020

vdaas-ci commented Jun 22, 2020

kevindiu left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Jun 22, 2020

vdaas-ci commented Jun 22, 2020

vdaas-ci commented Jun 22, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

Added test case for `internal/errorgroup` #494

Added test case for `internal/errorgroup` #494

hlts2 commented Jun 18, 2020 •

edited

Loading

codecov bot commented Jun 18, 2020 •

edited

Loading

pull-assistant bot commented Jun 22, 2020 •

edited

Loading