Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Helm Chart info #496

Merged
merged 3 commits into from
Jun 19, 2020
Merged

Update Helm Chart info #496

merged 3 commits into from
Jun 19, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jun 19, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

  • Update Helm Chart info.
  • Add ArtifactHub badge
  • (fix tests to run reviewdog correctly)

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx marked this pull request as ready for review June 19, 2020 03:41
@codecov
Copy link

codecov bot commented Jun 19, 2020

Codecov Report

Merging #496 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #496      +/-   ##
=========================================
- Coverage    8.03%   7.97%   -0.06%     
=========================================
  Files         394     401       +7     
  Lines       20419   20705     +286     
=========================================
+ Hits         1640    1651      +11     
- Misses      18548   18812     +264     
- Partials      231     242      +11     
Impacted Files Coverage Δ
...al/observability/exporter/prometheus/prometheus.go 0.00% <0.00%> (ø)
internal/observability/client/google/option.go 0.00% <0.00%> (ø)
...ability/exporter/stackdriver/stackdriver_option.go 5.17% <0.00%> (ø)
internal/observability/exporter/jaeger/jaeger.go 0.00% <0.00%> (ø)
...rvability/exporter/prometheus/prometheus_option.go 16.66% <0.00%> (ø)
.../observability/exporter/stackdriver/stackdriver.go 0.00% <0.00%> (ø)
...nal/observability/exporter/jaeger/jaeger_option.go 5.40% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update eef0ea5...1a56ccf. Read the comment docs.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 1ad8de1 into master Jun 19, 2020
@kpango kpango deleted the refactor/helm-charts/fix-meta-info branch June 19, 2020 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants