Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added test case for internal/file/watch/option_test.go #518

Merged
merged 1 commit into from
Jul 6, 2020
Merged

Added test case for internal/file/watch/option_test.go #518

merged 1 commit into from
Jul 6, 2020

Conversation

hlts2
Copy link
Contributor

@hlts2 hlts2 commented Jun 25, 2020 •
edited
Loading

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I added test case for internal/file/watch/option_test.go.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jun 25, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     feat: options test

Powered by Pull Assistant. Last update 20e2f9d ... 20e2f9d. Read the comment docs.

@hlts2
Copy link
Contributor Author

hlts2 commented Jun 29, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by hlts2 for branch: test/internal/file_watch_option

@vdaas-ci vdaas-ci force-pushed the test/internal/file_watch_option branch from 4139a9c to 891e9ee Compare June 29, 2020 01:35
@codecov
Copy link

codecov bot commented Jun 29, 2020 •
edited
Loading

Codecov Report

Merging #518 into master will decrease coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #518      +/-   ##
=========================================
- Coverage    9.28%   9.26%   -0.02%     
=========================================
  Files         402     402              
  Lines       20859   20831      -28     
=========================================
- Hits         1936    1931       -5     
+ Misses      18670   18647      -23     
  Partials      253     253
Impacted Files Coverage Δ
internal/config/log.go 0.00% <0.00%> (-100.00%) ⬇️
internal/config/tls.go 0.00% <0.00%> (-100.00%) ⬇️
internal/log/mock/logger.go 0.00% <0.00%> (-100.00%) ⬇️
internal/config/config.go 0.00% <0.00%> (-15.79%) ⬇️
internal/runner/runner.go 90.38% <0.00%> (-0.92%) ⬇️
internal/tls/tls.go 0.00% <0.00%> (ø)
pkg/meta/redis/usecase/meta.go 0.00% <0.00%> (ø)
pkg/agent/core/ngt/service/ngt.go 0.00% <0.00%> (ø)
internal/net/grpc/status/status.go 0.00% <0.00%> (ø)
pkg/meta/cassandra/usecase/meta.go 0.00% <0.00%> (ø)
... and 15 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a76ef1b...20e2f9d. Read the comment docs.

@kevindiu
Copy link
Contributor

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: test/internal/file_watch_option

@vdaas-ci vdaas-ci force-pushed the test/internal/file_watch_option branch from 891e9ee to 69c04ed Compare June 29, 2020 05:30
kevindiu
kevindiu previously approved these changes Jun 29, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/file_watch_option

@vdaas-ci vdaas-ci force-pushed the test/internal/file_watch_option branch from 69c04ed to c54acd5 Compare June 30, 2020 02:53
vankichi
vankichi previously approved these changes Jun 30, 2020
View reviewed changes
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/file_watch_option

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci previously approved these changes Jun 30, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi
Copy link
Contributor

vankichi commented Jul 6, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/file_watch_option

@hlts2 @actions-user
feat: options test
20e2f9d 
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and themself via 20e2f9d July 6, 2020 01:24
@vdaas-ci vdaas-ci force-pushed the test/internal/file_watch_option branch from c54acd5 to 20e2f9d Compare July 6, 2020 01:24
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci approved these changes Jul 6, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 94f6f1f into master Jul 6, 2020
@vankichi vankichi deleted the test/internal/file_watch_option branch July 6, 2020 01:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions GitHub Actions GitHub Actions left review comments

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@kevindiu kevindiu kevindiu left review comments

@vankichi vankichi vankichi left review comments

Assignees
No one assigned
Labels
area/internal priority/low size/XXL team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@hlts2 @vdaas-ci @kevindiu @vankichi