-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added internal/config/log test #530
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
[WARNING:INTCFG] Changes in |
Codecov Report
@@ Coverage Diff @@
## master #530 +/- ##
=========================================
+ Coverage 9.02% 9.10% +0.07%
=========================================
Files 402 402
Lines 20831 20831
=========================================
+ Hits 1881 1896 +15
+ Misses 18697 18681 -16
- Partials 253 254 +1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase |
[REBASE] Rebase triggered by vankichi for branch: test/internal/config-log |
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
3e0dbce
to
d806ad7
Compare
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
Signed-off-by: vdaas-ci <ci@vdaas.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Signed-off-by: vankichi kyukawa315@gmail.com
Description:
I added test of
internal/config/log.go
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: