Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added internal/config/log test #530

Merged
merged 6 commits into from
Jul 1, 2020
Merged

added internal/config/log test #530

merged 6 commits into from
Jul 1, 2020

Conversation

vankichi
Copy link
Contributor

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I added test of internal/config/log.go

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jun 30, 2020

Score: 0.83

Best reviewed: commit by commit


Optimal code review plan

     ✅ added internal/config/log test

     📝 add godoc

     ✅ update test name

     ♻️ fix

     ♻️ fix

     🤖 Update license headers / Format go codes and yaml files

Powered by Pull Assistant. Last update 509f95b ... c0effd6. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

internal/config/log_test.go Outdated Show resolved Hide resolved
internal/config/log_test.go Outdated Show resolved Hide resolved
internal/config/log_test.go Outdated Show resolved Hide resolved
internal/config/log_test.go Outdated Show resolved Hide resolved
internal/config/log_test.go Outdated Show resolved Hide resolved
internal/config/log_test.go Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Jun 30, 2020

Codecov Report

Merging #530 into master will increase coverage by 0.07%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #530      +/-   ##
=========================================
+ Coverage    9.02%   9.10%   +0.07%     
=========================================
  Files         402     402              
  Lines       20831   20831              
=========================================
+ Hits         1881    1896      +15     
+ Misses      18697   18681      -16     
- Partials      253     254       +1     
Impacted Files Coverage Δ
internal/config/log.go 100.00% <ø> (+100.00%) ⬆️
internal/errgroup/group.go 94.73% <0.00%> (+1.31%) ⬆️
internal/config/config.go 15.78% <0.00%> (+15.78%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0fd5d9...c0effd6. Read the comment docs.

kevindiu
kevindiu previously approved these changes Jun 30, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hlts2
hlts2 previously approved these changes Jul 1, 2020
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor Author

vankichi commented Jul 1, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 1, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/config-log

Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci vdaas-ci dismissed stale reviews from hlts2 and kevindiu via d806ad7 July 1, 2020 05:47
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 1, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 543898b into master Jul 1, 2020
@vankichi vankichi deleted the test/internal/config-log branch July 1, 2020 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants