Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add codeql config #532

Merged
merged 2 commits into from
Jul 1, 2020
Merged

add codeql config #532

merged 2 commits into from
Jul 1, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jul 1, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Add codeQL config.

(this PR includes the fix of several workflows.)

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jul 1, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     💚 add codeql config

     🐛 Fix bug on creating pull request for k8s dir

Powered by Pull Assistant. Last update c2144fb ... 673445c. Read the comment docs.

@rinx rinx force-pushed the ci/codeql/add-codeql-config branch 4 times, most recently from 445c132 to 30395c0 Compare July 1, 2020 03:17
rinx added 2 commits July 1, 2020 12:42
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the ci/codeql/add-codeql-config branch from 30395c0 to 673445c Compare July 1, 2020 03:43
@rinx rinx marked this pull request as ready for review July 1, 2020 04:53
@rinx rinx merged commit f0fd5d9 into master Jul 1, 2020
@rinx rinx deleted the ci/codeql/add-codeql-config branch July 1, 2020 04:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant