-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[agent-sidecar] Add cancel hook for file watcher #535
[agent-sidecar] Add cancel hook for file watcher #535
Conversation
Best reviewed: commit by commit
Optimal code review plan
|
if err != nil { | ||
return err | ||
} | ||
defer func() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[golangci] reported by reviewdog 🐶
only one cuddle assignment allowed before defer statement (wsl)
Codecov Report
@@ Coverage Diff @@
## master #535 +/- ##
=========================================
- Coverage 9.10% 9.09% -0.01%
=========================================
Files 402 402
Lines 20831 20837 +6
=========================================
Hits 1896 1896
- Misses 18681 18687 +6
Partials 254 254
Continue to review full report at Codecov.
|
/rebase |
[REBASE] Rebase triggered by rinx for branch: bugfix/agent-sidecar/add-cancel-hook-for-internal-file-watch |
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
1eac014
to
0567c23
Compare
[FORMAT] Updating license headers and formatting go codes triggered by rinx. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com
Description:
Added cancel hook for file watcher.
agent-sidecar does not stop correctly when it receives SIGTERM without it.
made the default post_stop_timeout longer.
Related Issue:
nothing.
How Has This Been Tested?:
nothing.
Environment:
Types of changes:
Changes to Core Features:
Checklist: