[agent-ngt] use Len and InsertVCacheLen method for IndexInfo / add mutex for (Create|Save)Index

[rinx]

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

use Len() and InsertVCacheLen() method for IndexInfo because the current implementation of IndexInfo does not returns correct values (maybe UUIDs method cannot count too many index).

add mutex for CreateIndex & SaveIndex.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

• Go Version: 1.14.3
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.11.5

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan

     ♻️ use Len() and InsertVCacheLen() method for IndexInfo

     ♻️ add mutex for create-index & save-index

     🔧 pass post_stop_timeout to sidecar observer service

Powered by Pull Assistant. Last update c7ddefb ... 04a8d4a. Read the comment docs.

[codecov]

Codecov Report

Merging #536 into master will increase coverage by 0.02%.
The diff coverage is 47.36%.

@@            Coverage Diff            @@
##           master    #536      +/-   ##
=========================================
+ Coverage    9.16%   9.18%   +0.02%     
=========================================
  Files         402     402              
  Lines       20848   20859      +11     
=========================================
+ Hits         1910    1916       +6     
- Misses      18685   18690       +5     
  Partials      253     253              

Impacted Files	Coverage Δ
pkg/agent/core/ngt/handler/grpc/handler.go	0.00% <0.00%> (ø)
pkg/agent/core/ngt/service/ngt.go	0.00% <0.00%> (ø)
pkg/agent/sidecar/usecase/sidecar/sidecar.go	0.00% <0.00%> (ø)
internal/runner/runner.go	91.30% <100.00%> (+0.47%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76908b6...04a8d4a. Read the comment docs.

[kpango]

LGTM

[rinx]

/format

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by rinx.