Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add log/mock/logger test #538

Merged
merged 1 commit into from
Jul 6, 2020
Merged

add log/mock/logger test #538

merged 1 commit into from
Jul 6, 2020

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jul 2, 2020

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I added test of internal/log/mock/logger and updated its godoc

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vankichi vankichi requested review from kevindiu and hlts2 July 2, 2020 04:33
@pull-assistant
Copy link

pull-assistant bot commented Jul 2, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     ✅ add log/mock/logger test

Powered by Pull Assistant. Last update 86f4414 ... 86f4414. Read the comment docs.

hlts2
hlts2 previously approved these changes Jul 2, 2020
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

github-actions[bot]
github-actions bot reviewed Jul 2, 2020
View reviewed changes
internal/log/mock/logger_test.go
wantVals := []interface{}{
"Vald",
}
wantFormat := "json"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[golangci] reported by reviewdog 🐶
string json has 5 occurrences, make it a constant (goconst)

@codecov
Copy link

codecov bot commented Jul 2, 2020 •
edited
Loading

Codecov Report

Merging #538 into master will increase coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #538      +/-   ##
=========================================
+ Coverage    9.18%   9.28%   +0.09%     
=========================================
  Files         402     402              
  Lines       20859   20859              
=========================================
+ Hits         1916    1936      +20     
+ Misses      18690   18670      -20     
  Partials      253     253
Impacted Files Coverage Δ
internal/log/mock/logger.go 100.00% <ø> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8296de9...86f4414. Read the comment docs.

@kevindiu
Copy link
Contributor

kevindiu commented Jul 2, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 2, 2020

[REBASE] Rebase triggered by kevindiu for branch: test/internal/log-mock-logger

@vdaas-ci vdaas-ci force-pushed the test/internal/log-mock-logger branch from 41fbf85 to 418b06c Compare July 2, 2020 07:27
kevindiu
kevindiu previously approved these changes Jul 2, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor Author

vankichi commented Jul 6, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/log-mock-logger

@vankichi @actions-user
✅ add log/mock/logger test
86f4414 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci vdaas-ci force-pushed the test/internal/log-mock-logger branch from 418b06c to 86f4414 Compare July 6, 2020 00:30
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci approved these changes Jul 6, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit a76ef1b into master Jul 6, 2020
@vankichi vankichi deleted the test/internal/log-mock-logger branch July 6, 2020 00:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@hlts2 hlts2 hlts2 left review comments

@kevindiu kevindiu kevindiu left review comments

Assignees
No one assigned
Labels
area/internal priority/low size/XXL team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vankichi @kevindiu @vdaas-ci @hlts2