Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add internal/singleflight test #542

Merged
merged 5 commits into from
Jul 7, 2020
Merged

add internal/singleflight test #542

merged 5 commits into from
Jul 7, 2020

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jul 2, 2020 •
edited
Loading

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I added the test of internal/singleflight and updated its godoc

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jul 2, 2020 •
edited
Loading

Score: 0.70

Best reviewed: commit by commit

Optimal code review plan (2 warnings)

✅ add internal/singleflight test

...l/singleflight/singleflight.go 75% changes removed in ♻️ fix

...gleflight/singleflight_test.go 46% changes removed in ♻️ fix

     Bug singleflight test (#547)

♻️ fix

...l/singleflight/singleflight.go 50% changes removed in ♻️ fix

     ♻️ fix

     ♻️ fix

Powered by Pull Assistant. Last update ce3b09a ... f804947. Read the comment docs.

@vankichi vankichi requested review from hlts2 and kevindiu July 2, 2020 09:00
@codecov
Copy link

codecov bot commented Jul 2, 2020 •
edited
Loading

Codecov Report

Merging #542 into master will increase coverage by 0.13%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master    #542      +/-   ##
=========================================
+ Coverage    9.51%   9.65%   +0.13%     
=========================================
  Files         402     402              
  Lines       20859   20859              
=========================================
+ Hits         1985    2013      +28     
+ Misses      18621   18593      -28     
  Partials      253     253
Impacted Files Coverage Δ
internal/log/mock/retry.go 100.00% <ø> (+100.00%) ⬆️
internal/singleflight/singleflight.go 100.00% <ø> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b43b4be...f804947. Read the comment docs.

@vankichi
Copy link
Contributor Author

vankichi commented Jul 6, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/singleflight

@vankichi
Copy link
Contributor Author

vankichi commented Jul 6, 2020

/rebase

@vdaas-ci vdaas-ci force-pushed the test/internal/singleflight branch from 98f5cd6 to 7040107 Compare July 6, 2020 00:53
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/singleflight

@vankichi
Copy link
Contributor Author

vankichi commented Jul 6, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/singleflight

@vdaas-ci vdaas-ci force-pushed the test/internal/singleflight branch from 2f9c18a to 3e5c4f4 Compare July 6, 2020 02:53
@vankichi
Copy link
Contributor Author

vankichi commented Jul 6, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/singleflight

@vdaas-ci vdaas-ci force-pushed the test/internal/singleflight branch from 3e5c4f4 to d79c15b Compare July 6, 2020 05:31
github-actions[bot]
github-actions bot reviewed Jul 6, 2020
View reviewed changes
internal/singleflight/singleflight.go Outdated Show resolved Hide resolved
internal/singleflight/singleflight_test.go Outdated Show resolved Hide resolved
internal/singleflight/singleflight_test.go Outdated Show resolved Hide resolved
internal/singleflight/singleflight_test.go Outdated Show resolved Hide resolved
@vankichi
Copy link
Contributor Author

vankichi commented Jul 6, 2020

/rebase
/format

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/singleflight

@vankichi vankichi changed the title [WIP] add internal/singleflight test add internal/singleflight test Jul 6, 2020
@vankichi vankichi marked this pull request as ready for review July 6, 2020 07:10
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

kevindiu
kevindiu previously approved these changes Jul 6, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hlts2
hlts2 previously approved these changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor Author

vankichi commented Jul 7, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 7, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/singleflight

vankichi and others added 5 commits July 7, 2020 07:26
@vankichi @actions-user
✅ add internal/singleflight test
ce3b09a 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@hlts2 @actions-user
Bug singleflight test (#547)
e8f0a3d 
* fix: test case

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: comment out

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

* fix: delete unncessary code

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vankichi @actions-user
♻️ fix
0382e7d 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @actions-user
♻️ fix
da7b768 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi @actions-user
♻️ fix
f804947 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci vdaas-ci dismissed stale reviews from hlts2 and kevindiu via f804947 July 7, 2020 07:26
@vdaas-ci vdaas-ci force-pushed the test/internal/singleflight branch from 77ca32c to f804947 Compare July 7, 2020 07:26
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 7, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci approved these changes Jul 7, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit c36a548 into master Jul 7, 2020
@vankichi vankichi deleted the test/internal/singleflight branch July 7, 2020 07:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@hlts2 hlts2 hlts2 left review comments

@kevindiu kevindiu kevindiu left review comments

Assignees
No one assigned
Labels
area/internal priority/low size/L team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vankichi @vdaas-ci @kevindiu @hlts2