Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI tests] exclude hack codes #543

Merged
merged 5 commits into from
Jul 2, 2020
Merged

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jul 2, 2020

Description:

Run tests only for cmd, internal, pkg packages when PR check.
Add chatops help.

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

rinx added 2 commits July 2, 2020 17:54
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented Jul 2, 2020

Score: 0.90

Best reviewed: commit by commit


Optimal code review plan (2 warnings)

     ✅ exclude hack tests

     💚 add chatops help

💚 Fix

...hub/workflows/chatops-help.yml 50% changes removed in 💚 ok

💚 ok

...hub/workflows/chatops-help.yml 50% changes removed in 🔥 remove redund...

     🔥 remove redundant codes

Powered by Pull Assistant. Last update c7d7cef ... 93a5db6. Read the comment docs.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas vdaas deleted a comment from vdaas-ci Jul 2, 2020
@rinx rinx closed this Jul 2, 2020
@rinx rinx reopened this Jul 2, 2020
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 2, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@vdaas-ci vdaas-ci added ` labels Jul 2, 2020
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx removed - labels Jul 2, 2020
@rinx rinx marked this pull request as ready for review July 2, 2020 09:28
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx merged commit 02db131 into master Jul 2, 2020
@rinx rinx deleted the ci/run-tests/exclude-hack-codes branch July 2, 2020 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants