Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix condition check of chatops #544

Merged
merged 1 commit into from
Jul 3, 2020
Merged

Fix condition check of chatops #544

merged 1 commit into from
Jul 3, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jul 3, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

SSIA

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@rinx
🐛 Fix condition check of chatops
b85707b 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented Jul 3, 2020

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     🐛 Fix condition check of chatops

Powered by Pull Assistant. Last update b85707b ... b85707b. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 3, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@rinx rinx merged commit 8296de9 into master Jul 3, 2020
@rinx rinx deleted the ci/chatops/fix-condition-check-of-chatops branch July 3, 2020 03:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
priority/low size/S team/sre SRE team type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@rinx @vdaas-ci