Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

not to force rebuild gotests #548

Merged
merged 2 commits into from
Jul 7, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jul 6, 2020

Description:

i found there's no need to force rebuild gotests.
removed dockfmt.

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.14.3
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.11.5

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jul 6, 2020

Score: NaN

Best reviewed: with all changes


Optimal code review plan (2 commits squashed)

🔧 not to forc... ... 🔥 remove dockfm...

Squashed 2 commits:

Powered by Pull Assistant. Last update feec0d0 ... 04cb917. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 6, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@rinx
Copy link
Contributor Author

rinx commented Jul 7, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Jul 7, 2020

[REBASE] Rebase triggered by rinx for branch: refactor/makefile/not-to-force-rebuild-gotests

rinx added 2 commits July 7, 2020 00:25
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the refactor/makefile/not-to-force-rebuild-gotests branch from 8f45ea6 to 04cb917 Compare July 7, 2020 00:25
@rinx
Copy link
Contributor Author

rinx commented Jul 7, 2020

changes are only for Makefile, so i'm going to merge it.

@rinx rinx merged commit b43b4be into master Jul 7, 2020
@rinx rinx deleted the refactor/makefile/not-to-force-rebuild-gotests branch July 7, 2020 00:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants