Add test case for `internal/file` #550

hlts2 · 2020-07-06T06:12:51Z

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I added test case for internal/file.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.14.3
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.11.5

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-07-06T06:12:53Z

Best reviewed: commit by commit

Optimal code review plan

feat: test case

fix: permission

fix: apply suggestion

fix: add comment

fix: apply suggestion

Powered by Pull Assistant. Last update d4159ee ... 81d16f2. Read the comment docs.

vdaas-ci · 2020-07-06T06:13:08Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

codecov · 2020-07-06T06:20:46Z

Codecov Report

Merging #550 into master will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##           master    #550      +/-   ##
=========================================
+ Coverage    9.65%   9.70%   +0.05%     
=========================================
  Files         402     402              
  Lines       20859   20859              
=========================================
+ Hits         2013    2025      +12     
+ Misses      18593   18577      -16     
- Partials      253     257       +4

Impacted Files	Coverage Δ
internal/file/file.go	`60.00% <ø> (+60.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c36a548...81d16f2. Read the comment docs.

kevindiu · 2020-07-06T07:05:02Z

the test is fail..

% go test ./...
--- FAIL: TestOpen (0.00s)
    --- FAIL: TestOpen/returns_*os.File_when_path_is_`test/data` (0.00s)
        file_test.go:125: error = open test/data: permission denied
FAIL
FAIL	github.com/vdaas/vald/internal/file	2.045s
ok  	github.com/vdaas/vald/internal/file/watch	1.746s
FAIL

kevindiu · 2020-07-06T08:28:45Z

Please add comment to the Open() function

internal/file/file_test.go

hlts2 · 2020-07-06T23:52:41Z

/rebase

vdaas-ci · 2020-07-06T23:53:15Z

[REBASE] Rebase triggered by hlts2 for branch: test/internal/file

kevindiu

LGTM

vankichi · 2020-07-07T07:36:45Z

@hlts2 Could you please add comment of Open()?
https://github.com/vdaas/vald/blob/master/internal/file/file.go#L25

internal/file/file.go

kevindiu

LGTM

vankichi

LGTM

vankichi · 2020-07-07T08:15:47Z

/rebase
/format
/approve

vdaas-ci · 2020-07-07T08:23:56Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/file

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

vdaas-ci · 2020-07-07T08:28:06Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

github-actions bot added area/internal team/set SET team labels Jul 6, 2020

hlts2 requested a review from kevindiu July 6, 2020 06:13

github-actions bot added size/M type/test Adding tests priority/low labels Jul 6, 2020

hlts2 self-assigned this Jul 6, 2020

kevindiu reviewed Jul 6, 2020

View reviewed changes

internal/file/file_test.go Show resolved Hide resolved

vdaas-ci force-pushed the test/internal/file branch from 7716e95 to efaabac Compare July 6, 2020 23:53

github-actions bot added size/L and removed size/M labels Jul 7, 2020

kevindiu previously approved these changes Jul 7, 2020

View reviewed changes

hlts2 requested a review from vankichi July 7, 2020 06:13

hlts2 dismissed kevindiu’s stale review via 1ad78ba July 7, 2020 07:42

kevindiu reviewed Jul 7, 2020

View reviewed changes

internal/file/file.go Outdated Show resolved Hide resolved

kevindiu previously approved these changes Jul 7, 2020

View reviewed changes

vankichi previously approved these changes Jul 7, 2020

View reviewed changes

hlts2 added 3 commits July 7, 2020 08:24

feat: test case

d4159ee

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: permission

f001dda

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: apply suggestion

66730bf

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

hlts2 added 2 commits July 7, 2020 08:24

fix: add comment

6448cb4

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: apply suggestion

81d16f2

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

vdaas-ci dismissed stale reviews from vankichi and kevindiu via 81d16f2 July 7, 2020 08:24

vdaas-ci force-pushed the test/internal/file branch from a38b1a5 to 81d16f2 Compare July 7, 2020 08:24

vdaas-ci approved these changes Jul 7, 2020

View reviewed changes

vankichi merged commit 94e4c6f into master Jul 7, 2020

vankichi deleted the test/internal/file branch July 7, 2020 08:33

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add test case for `internal/file` #550

Add test case for `internal/file` #550

hlts2 commented Jul 6, 2020 •

edited

Loading

pull-assistant bot commented Jul 6, 2020 •

edited

Loading

vdaas-ci commented Jul 6, 2020

codecov bot commented Jul 6, 2020 •

edited

Loading

kevindiu commented Jul 6, 2020

kevindiu commented Jul 6, 2020

hlts2 commented Jul 6, 2020

vdaas-ci commented Jul 6, 2020

kevindiu left a comment

vankichi commented Jul 7, 2020

kevindiu left a comment

vankichi left a comment

vankichi commented Jul 7, 2020

vdaas-ci commented Jul 7, 2020

vdaas-ci commented Jul 7, 2020

vdaas-ci left a comment

Add test case for internal/file #550

Add test case for internal/file #550

Conversation

hlts2 commented Jul 6, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Jul 6, 2020 • edited Loading

vdaas-ci commented Jul 6, 2020

codecov bot commented Jul 6, 2020 • edited Loading

Codecov Report

kevindiu commented Jul 6, 2020

kevindiu commented Jul 6, 2020

hlts2 commented Jul 6, 2020

vdaas-ci commented Jul 6, 2020

kevindiu left a comment

Choose a reason for hiding this comment

vankichi commented Jul 7, 2020

kevindiu left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Jul 7, 2020

vdaas-ci commented Jul 7, 2020

vdaas-ci commented Jul 7, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

Add test case for `internal/file` #550

Add test case for `internal/file` #550

hlts2 commented Jul 6, 2020 •

edited

Loading

pull-assistant bot commented Jul 6, 2020 •

edited

Loading

codecov bot commented Jul 6, 2020 •

edited

Loading