refactor load test #552

kmrmt · 2020-07-06T07:50:11Z

Description:

Refactor load test.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

Go Version: 1.14.2
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.11.4

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-07-06T07:50:14Z

Best reviewed: commit by commit

Optimal code review plan (4 warnings)

refactor load test

...oadtest/service/insert_test.go 67% changes removed in fix for ci

...oadtest/service/loader_test.go 67% changes removed in fix for ci

...oadtest/service/search_test.go 67% changes removed in fix for ci

fix format

use raw grpc client

...cli/loadtest/service/loader.go 56% changes removed in refactor based on co...

gofmt

...cli/loadtest/service/loader.go 57% changes removed in refactor based on co...

bug fix

fix based on comments

fix error check

refactor based on comment

refactor

🤖 Update license headers / Format go codes and yaml files

...cli/loadtest/service/loader.go 50% changes removed in fix for ci

fix for ci

Powered by Pull Assistant. Last update b5e700a ... 0985a92. Read the comment docs.

vdaas-ci · 2020-07-06T07:50:30Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

codecov · 2020-07-06T07:58:20Z

Codecov Report

Merging #552 into master will decrease coverage by 0.10%.
The diff coverage is 0.37%.

@@            Coverage Diff             @@
##           master     #552      +/-   ##
==========================================
- Coverage   13.33%   13.22%   -0.11%     
==========================================
  Files         409      409              
  Lines       21341    21516     +175     
==========================================
  Hits         2845     2845              
- Misses      18220    18394     +174     
- Partials      276      277       +1

Impacted Files	Coverage Δ
pkg/tools/cli/loadtest/assets/loader.go	`0.00% <0.00%> (ø)`
pkg/tools/cli/loadtest/config/config.go	`0.00% <0.00%> (ø)`
pkg/tools/cli/loadtest/service/insert.go	`0.00% <0.00%> (ø)`
pkg/tools/cli/loadtest/service/loader.go	`0.00% <0.00%> (ø)`
pkg/tools/cli/loadtest/service/search.go	`0.00% <0.00%> (ø)`
pkg/tools/cli/loadtest/usecase/load.go	`0.00% <0.00%> (ø)`
pkg/tools/cli/loadtest/service/loader_option.go	`8.33% <7.69%> (+0.22%)`	⬆️
internal/errgroup/group.go	`93.42% <0.00%> (-1.32%)`	⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3d5073...0985a92. Read the comment docs.

pkg/tools/cli/loadtest/service/loader.go

pkg/tools/cli/loadtest/service/search.go

pkg/tools/cli/loadtest/service/loader.go

kevindiu

LGTM

vankichi

LGTM

pkg/tools/cli/loadtest/assets/loader.go

pkg/tools/cli/loadtest/service/insert.go

pkg/tools/cli/loadtest/usecase/load.go

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

vdaas-ci · 2020-08-06T03:18:26Z

[FORMAT] Failed to format.

vdaas-ci · 2020-08-06T03:19:30Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci

[APPROVED] This PR is approved by vankichi.

vankichi · 2020-08-06T05:34:20Z

@kmrmt Could you please fix failing test?

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

pkg/tools/cli/loadtest/service/loader.go

pkg/tools/cli/loadtest/service/search.go

pkg/tools/cli/loadtest/service/loader.go

pkg/tools/cli/loadtest/service/search.go

pkg/tools/cli/loadtest/service/loader.go

pkg/tools/cli/loadtest/service/insert.go

hlts2

LGTM

kevindiu

LGTM

vankichi

LGTM

vankichi · 2020-08-06T08:27:39Z

/rebase
/format
/approve

vdaas-ci · 2020-08-06T08:28:15Z

[REBASE] Rebase triggered by vankichi for branch: feature/benchmark/load_test_refactor

vdaas-ci · 2020-08-06T08:30:43Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

kmrmt requested review from kevindiu and hlts2 July 6, 2020 07:50

github-actions bot added area/tools/cli/loadtest team/set SET team size/L type/feature New feature priority/medium labels Jul 6, 2020

kmrmt added priority/low and removed priority/medium labels Jul 6, 2020

kmrmt force-pushed the feature/benchmark/load_test_refactor branch from 6ffddd7 to 90952ac Compare July 6, 2020 09:22

github-actions bot added priority/medium size/XL and removed priority/low size/L labels Jul 6, 2020

kevindiu reviewed Jul 10, 2020

View reviewed changes

pkg/tools/cli/loadtest/service/loader.go Show resolved Hide resolved

hlts2 reviewed Jul 28, 2020

View reviewed changes

pkg/tools/cli/loadtest/service/search.go Outdated Show resolved Hide resolved

hlts2 reviewed Jul 28, 2020

View reviewed changes

pkg/tools/cli/loadtest/service/search.go Outdated Show resolved Hide resolved

hlts2 reviewed Jul 28, 2020

View reviewed changes

pkg/tools/cli/loadtest/service/loader.go Outdated Show resolved Hide resolved

kevindiu self-requested a review July 29, 2020 01:12

kevindiu reviewed Jul 29, 2020

View reviewed changes

pkg/tools/cli/loadtest/service/loader.go Outdated Show resolved Hide resolved

kevindiu previously approved these changes Jul 29, 2020

View reviewed changes

vankichi previously approved these changes Jul 30, 2020

View reviewed changes

hlts2 reviewed Jul 30, 2020

View reviewed changes

pkg/tools/cli/loadtest/assets/loader.go Outdated Show resolved Hide resolved

hlts2 reviewed Jul 30, 2020

View reviewed changes

pkg/tools/cli/loadtest/service/insert.go Show resolved Hide resolved

kmrmt dismissed stale reviews from vankichi and kevindiu via b541c1a July 30, 2020 04:04

hlts2 reviewed Jul 30, 2020

View reviewed changes

pkg/tools/cli/loadtest/usecase/load.go Show resolved Hide resolved

kmrmt added 9 commits August 6, 2020 03:18

gofmt

095081d

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

bug fix

634063e

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

fix based on comments

17d7692

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

fix based on comments

54908e9

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

fix based on comments

52028eb

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

fix error check

db2b185

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

fix error check

45936bd

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

refactor based on comment

48f8375

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

refactor

028925c

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

vdaas-ci force-pushed the feature/benchmark/load_test_refactor branch from 8111b31 to 028925c Compare August 6, 2020 03:18

🤖 Update license headers / Format go codes and yaml files

360e3ff

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci previously approved these changes Aug 6, 2020

View reviewed changes

fix for ci

0985a92

Signed-off-by: Kosuke Morimoto <kou.morimoto@gmail.com>

kmrmt dismissed vdaas-ci’s stale review via 0985a92 August 6, 2020 06:52

github-actions bot added size/XXL and removed size/XL labels Aug 6, 2020

github-actions bot reviewed Aug 6, 2020

View reviewed changes

hlts2 approved these changes Aug 6, 2020

View reviewed changes

kevindiu approved these changes Aug 6, 2020

View reviewed changes

vankichi approved these changes Aug 6, 2020

View reviewed changes

vdaas-ci approved these changes Aug 6, 2020

View reviewed changes

vankichi merged commit 2e2581b into master Aug 6, 2020

vankichi deleted the feature/benchmark/load_test_refactor branch August 6, 2020 08:53

vdaas-ci mentioned this pull request Sep 2, 2020

[patch] update deps #660

Merged

18 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

refactor load test #552

refactor load test #552

kmrmt commented Jul 6, 2020

pull-assistant bot commented Jul 6, 2020 •

edited

Loading

vdaas-ci commented Jul 6, 2020

codecov bot commented Jul 6, 2020 •

edited

Loading

kevindiu left a comment

vankichi left a comment

vdaas-ci commented Aug 6, 2020

vdaas-ci commented Aug 6, 2020

vdaas-ci left a comment

vankichi commented Aug 6, 2020

hlts2 left a comment

kevindiu left a comment

vankichi left a comment

vankichi commented Aug 6, 2020

vdaas-ci commented Aug 6, 2020

vdaas-ci commented Aug 6, 2020

vdaas-ci left a comment

refactor load test #552

refactor load test #552

Conversation

kmrmt commented Jul 6, 2020

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Jul 6, 2020 • edited Loading

vdaas-ci commented Jul 6, 2020

codecov bot commented Jul 6, 2020 • edited Loading

Codecov Report

kevindiu left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vdaas-ci commented Aug 6, 2020

vdaas-ci commented Aug 6, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

vankichi commented Aug 6, 2020

hlts2 left a comment

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Aug 6, 2020

vdaas-ci commented Aug 6, 2020

vdaas-ci commented Aug 6, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

pull-assistant bot commented Jul 6, 2020 •

edited

Loading

codecov bot commented Jul 6, 2020 •

edited

Loading