add internal/cache/gache/option test #575

vankichi · 2020-07-13T02:06:32Z

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I added internal/cache/gache/option test and updated comment for each function.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.14.4
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.0

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-07-13T02:06:35Z

Best reviewed: commit by commit

Optimal code review plan

✅ add internal/cache/gache/option test

♻️ use gocmp for check value

♻️ add comment

Powered by Pull Assistant. Last update 7b63d59 ... 8e1082c. Read the comment docs.

vdaas-ci · 2020-07-13T02:06:56Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

github-actions · 2020-07-13T02:12:54Z

internal/cache/gache/option_test.go

+				WithGache(gache.New()),
+			}
+			return test{
+				name: "set sucess",


[golangci] _{reported by reviewdog 🐶}
sucess is a misspelling of success (misspell)

codecov · 2020-07-13T02:20:25Z

Codecov Report

Merging #575 into master will increase coverage by 0.08%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #575      +/-   ##
==========================================
+ Coverage   10.77%   10.86%   +0.08%     
==========================================
  Files         403      403              
  Lines       20939    20939              
==========================================
+ Hits         2257     2275      +18     
+ Misses      18414    18396      -18     
  Partials      268      268

Impacted Files	Coverage Δ
internal/cache/gache/option.go	`100.00% <ø> (+100.00%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8021b5e...8e1082c. Read the comment docs.

internal/cache/gache/option_test.go

vankichi · 2020-07-13T06:14:58Z

/rebase

vankichi · 2020-07-13T08:14:37Z

/rebase

vdaas-ci · 2020-07-13T08:15:19Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/cache-gache-option

vankichi · 2020-07-13T08:40:25Z

/rebase
/format

vdaas-ci · 2020-07-13T08:44:17Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/cache-gache-option

Signed-off-by: vankichi <kyukawa315@gmail.com>

vdaas-ci · 2020-07-13T08:48:20Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

internal/cache/gache/option.go

Signed-off-by: vankichi <kyukawa315@gmail.com>

kevindiu

LGTM

hlts2

LGTM

Signed-off-by: vankichi <kyukawa315@gmail.com>

vankichi · 2020-07-14T04:50:04Z

/rebase
/format
/approve

vdaas-ci · 2020-07-14T04:52:55Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/cache-gache-option

vdaas-ci · 2020-07-14T04:53:57Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

kevindiu

LGTM

vankichi requested review from kevindiu and hlts2 July 13, 2020 02:06

github-actions bot added area/internal team/set SET team size/XL type/test Adding tests priority/low labels Jul 13, 2020

github-actions bot reviewed Jul 13, 2020

View reviewed changes

hlts2 reviewed Jul 13, 2020

View reviewed changes

internal/cache/gache/option_test.go Outdated Show resolved Hide resolved

vankichi marked this pull request as ready for review July 13, 2020 06:13

vankichi added 2 commits July 13, 2020 08:44

✅ add internal/cache/gache/option test

7b63d59

Signed-off-by: vankichi <kyukawa315@gmail.com>

♻️ use gocmp for check value

0d384f0

Signed-off-by: vankichi <kyukawa315@gmail.com>

vdaas-ci force-pushed the test/internal/cache-gache-option branch from 8859f44 to 0d384f0 Compare July 13, 2020 08:44

kevindiu reviewed Jul 13, 2020

View reviewed changes

internal/cache/gache/option.go Show resolved Hide resolved

♻️ add comment

061c5ee

Signed-off-by: vankichi <kyukawa315@gmail.com>

kevindiu previously approved these changes Jul 14, 2020

View reviewed changes

hlts2 previously approved these changes Jul 14, 2020

View reviewed changes

♻️ add comment

8e1082c

Signed-off-by: vankichi <kyukawa315@gmail.com>

vankichi dismissed stale reviews from hlts2 and kevindiu via 8e1082c July 14, 2020 04:49

vdaas-ci approved these changes Jul 14, 2020

View reviewed changes

kevindiu approved these changes Jul 14, 2020

View reviewed changes

vankichi merged commit 78db9e2 into master Jul 14, 2020

vankichi deleted the test/internal/cache-gache-option branch July 14, 2020 07:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

add internal/cache/gache/option test #575

add internal/cache/gache/option test #575

vankichi commented Jul 13, 2020

pull-assistant bot commented Jul 13, 2020 •

edited

Loading

vdaas-ci commented Jul 13, 2020

github-actions bot Jul 13, 2020

codecov bot commented Jul 13, 2020 •

edited

Loading

vankichi commented Jul 13, 2020

vankichi commented Jul 13, 2020

vdaas-ci commented Jul 13, 2020

vankichi commented Jul 13, 2020

vdaas-ci commented Jul 13, 2020

vdaas-ci commented Jul 13, 2020

kevindiu left a comment

hlts2 left a comment

vankichi commented Jul 14, 2020

vdaas-ci commented Jul 14, 2020

vdaas-ci commented Jul 14, 2020

vdaas-ci left a comment

kevindiu left a comment

add internal/cache/gache/option test #575

add internal/cache/gache/option test #575

Conversation

vankichi commented Jul 13, 2020

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Jul 13, 2020 • edited Loading

vdaas-ci commented Jul 13, 2020

github-actions bot Jul 13, 2020

Choose a reason for hiding this comment

codecov bot commented Jul 13, 2020 • edited Loading

Codecov Report

vankichi commented Jul 13, 2020

vankichi commented Jul 13, 2020

vdaas-ci commented Jul 13, 2020

vankichi commented Jul 13, 2020

vdaas-ci commented Jul 13, 2020

vdaas-ci commented Jul 13, 2020

kevindiu left a comment

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

vankichi commented Jul 14, 2020

vdaas-ci commented Jul 14, 2020

vdaas-ci commented Jul 14, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

kevindiu left a comment

Choose a reason for hiding this comment

pull-assistant bot commented Jul 13, 2020 •

edited

Loading

codecov bot commented Jul 13, 2020 •

edited

Loading