-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add internal/net/http/transport/option test #594
Conversation
Signed-off-by: vankichi <kyukawa315@gmail.com>
Best reviewed: commit by commit
Optimal code review plan (1 warning)
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov Report
@@ Coverage Diff @@
## master #594 +/- ##
=======================================
Coverage 11.80% 11.80%
=======================================
Files 407 407
Lines 21227 21227
=======================================
Hits 2505 2505
Misses 18445 18445
Partials 277 277
Continue to review full report at Codecov.
|
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTMed
/rebase |
[REBASE] Rebase triggered by vankichi for branch: test/internal/net_http_transport_option |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Signed-off-by: vankichi kyukawa315@gmail.com
Description:
I updated
internal/net/http/transport/option
test with new template and added comment each external function and vals.Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: