Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add internal/net/http/transport/option test #594

Merged
merged 8 commits into from
Jul 28, 2020

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Jul 28, 2020

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I updated internal/net/http/transport/option test with new template and added comment each external function and vals.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: vankichi <kyukawa315@gmail.com>
@pull-assistant
Copy link

pull-assistant bot commented Jul 28, 2020

@vankichi vankichi requested review from hlts2 and kevindiu July 28, 2020 06:02
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

Signed-off-by: vankichi <kyukawa315@gmail.com>
@codecov
Copy link

codecov bot commented Jul 28, 2020

Codecov Report

Merging #594 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #594   +/-   ##
=======================================
  Coverage   11.80%   11.80%           
=======================================
  Files         407      407           
  Lines       21227    21227           
=======================================
  Hits         2505     2505           
  Misses      18445    18445           
  Partials      277      277           
Impacted Files Coverage Δ
internal/net/http/transport/option.go 100.00% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6d215f6...23d10bb. Read the comment docs.

internal/net/http/transport/option_test.go Outdated Show resolved Hide resolved
internal/net/http/transport/option_test.go Outdated Show resolved Hide resolved
internal/net/http/transport/option.go Outdated Show resolved Hide resolved
internal/net/http/transport/option.go Outdated Show resolved Hide resolved
vankichi and others added 4 commits July 28, 2020 15:18
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
internal/net/http/transport/option.go Outdated Show resolved Hide resolved
internal/net/http/transport/option.go Outdated Show resolved Hide resolved
vankichi and others added 2 commits July 28, 2020 15:32
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTMed

@vankichi
Copy link
Contributor Author

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/net_http_transport_option

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 4cf5754 into master Jul 28, 2020
@vankichi vankichi deleted the test/internal/net_http_transport_option branch July 28, 2020 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants