[bugfix] fix behavior when index path is empty

[rinx]

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

from v0.0.47, when agent.ngt.index_path is empty, agent-ngt returns [FATAL]: remove .: invalid argument error and exit immediately.
the cause of this problem is the forgotten empty string check codes.
so i added a empty string check to WithIndexPath function.

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

• Go Version: 1.14.4
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.0

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan

     🐛 fix behavior when index path is empty

Powered by Pull Assistant. Last update df490be ... df490be. Read the comment docs.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[codecov]

Codecov Report

Merging #596 into master will decrease coverage by 0.00%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #596      +/-   ##
==========================================
- Coverage   11.80%   11.79%   -0.01%     
==========================================
  Files         407      407              
  Lines       21227    21229       +2     
==========================================
- Hits         2505     2504       -1     
- Misses      18445    18448       +3     
  Partials      277      277              

Impacted Files	Coverage Δ
pkg/agent/core/ngt/service/option.go	12.76% <0.00%> (-0.28%)	⬇️
internal/errgroup/group.go	93.42% <0.00%> (-1.32%)	⬇️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cf5754...df490be. Read the comment docs.

[kpango]

LGTM