Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add update dataflow in architecture document #601

Merged
merged 43 commits into from
Aug 7, 2020

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Jul 28, 2020

Signed-off-by: hlts2 hiroto.funakoshi.hiroto@gmail.com

Description:

I added Vald update data flow in architecture document and image files.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jul 28, 2020

Score: 0.69

Best reviewed: commit by commit


Optimal code review plan (7 warnings, 2 commits squashed)

feat: update flow

docs/overview/architecture.md 62% changes removed in fix: apply suggestio...

feat: add steps of update dataflow

docs/overview/architecture.md 88% changes removed in feat: add image

fix: typo ... fix: improve content...

Squashed 2 commits:

docs/overview/architecture.md 67% changes removed in Update docs/overview...

fix: on -> in

docs/overview/architecture.md 50% changes removed in Update docs/overview...

feat: add image

docs/overview/architecture.md 50% changes removed in Update docs/overview...

     feat: add image tag

     fix: update image

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     fix: update image

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     feat: git rebase master

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     fix: apply suggestion

fix: apply suggestion

docs/overview/architecture.md 67% changes removed in fix: apply suggestio...

     fix: apply suggestion

     fix: apply suggestion

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

     Update docs/overview/architecture.md

fix: all of the -> all the

docs/overview/architecture.md 50% changes removed in Update docs/overview...

     Update docs/overview/architecture.md

Powered by Pull Assistant. Last update 837ebdd ... 7b789e0. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@github-actions github-actions bot added size/M and removed size/S labels Jul 30, 2020
docs/overview/architecture.md Outdated Show resolved Hide resolved
assets/docs/update_flow.drawio Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
@hlts2 hlts2 changed the title [WIP] Add update dataflow in architecture document Add update dataflow in architecture document Jul 31, 2020
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
docs/overview/architecture.md Outdated Show resolved Hide resolved
kevindiu
kevindiu previously approved these changes Aug 3, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Please rebase.

@hlts2
Copy link
Collaborator Author

hlts2 commented Aug 4, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 4, 2020

[REBASE] Rebase triggered by hlts2 for branch: documentaion/docs/add-update-flow-in-architecture

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 4, 2020

[REBASE] Failed to rebase.

@hlts2 hlts2 requested a review from vankichi August 4, 2020 01:35
@hlts2 hlts2 self-assigned this Aug 4, 2020
@hlts2 hlts2 changed the title Add update dataflow in architecture document Add update dataflow in architecture documentaion Aug 4, 2020
@hlts2 hlts2 changed the title Add update dataflow in architecture documentaion Add update dataflow in architecture document Aug 4, 2020
@hlts2 hlts2 force-pushed the documentaion/docs/add-update-flow-in-architecture branch from 59913b6 to 9f41c0f Compare August 4, 2020 08:10
kevindiu
kevindiu previously approved these changes Aug 4, 2020
@hlts2 hlts2 marked this pull request as ready for review August 4, 2020 08:32
hlts2 and others added 23 commits August 7, 2020 01:14
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kevin Diu <kevin_diu@yahoo.com.hk>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
@vdaas-ci vdaas-ci force-pushed the documentaion/docs/add-update-flow-in-architecture branch from 6048353 to 7b789e0 Compare August 7, 2020 01:14
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 7, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 2ee77ce into master Aug 7, 2020
@vankichi vankichi deleted the documentaion/docs/add-update-flow-in-architecture branch August 7, 2020 01:37
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants