Add internal/worker/worker test

[kevindiu]

Author review required.

Description:

This PR includes the following changes:

• implements internal/worker test code
• create test/comparator package and implement go-cmp comparator
• missing close(ech) in startJobLoop()

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.14.4
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.0

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan (6 warnings)

add test

internal/worker/worker_test.go 42% changes removed in fix

create comparator

...al/test/comparator/standard.go 40% changes removed in comment unused code

internal/worker/worker_test.go 42% changes removed in fix

add test

internal/worker/worker.go 69% changes removed in revert changes and u...

remove unused code

internal/worker/worker.go 93% changes removed in fix

     update comment

do not use comparator

internal/worker/worker_test.go 77% changes removed in fix

     comment unused code

fix

...al/test/comparator/standard.go 50% changes removed in revert changes and u...

     fix

     fix

     revert changes and use alias for go-cmp

     fix

     fix

     🤖 Update license headers / Format go codes and yaml files

     fix Makefile

     fix

Powered by Pull Assistant. Last update c0cd3b4 ... ad07b1b. Read the comment docs.

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[codecov]

Codecov Report

Merging #602 into master will decrease coverage by 0.28%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #602      +/-   ##
==========================================
- Coverage   13.22%   12.94%   -0.29%     
==========================================
  Files         409      405       -4     
  Lines       21516    21294     -222     
==========================================
- Hits         2846     2757      -89     
+ Misses      18393    18264     -129     
+ Partials      277      273       -4     

Impacted Files	Coverage Δ
internal/worker/worker_option.go
internal/worker/queue.go
internal/worker/queue_option.go

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e2581b...ad07b1b. Read the comment docs.

[kevindiu]

/rebase

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/worker

[kevindiu]

/rebase

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/worker

[kevindiu]

/rebase

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/worker

[vankichi]

/rebase
/format
/approve

[vdaas-ci]

[REBASE] Rebase triggered by vankichi for branch: test/internal/worker

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

[vdaas-ci]

[APPROVED] This PR is approved by vankichi.

[kpango]

LGTM