Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use distroless for base image #605

Merged
merged 21 commits into from
Aug 11, 2020
Merged

use distroless for base image #605

merged 21 commits into from
Aug 11, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Jul 30, 2020 •
edited
Loading

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

  • use distroless for base image
  • use trivy for image scan
  • "version" property for PR builds are now "PR-XXX" format
  • build binaries and publish them when released (only for linux)
  • fix info.BuildTime default value

Related Issue:

nothing.

How Has This Been Tested?:

nothing.

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Jul 30, 2020 •
edited
Loading

Score: 0.90

Best reviewed: commit by commit

Optimal code review plan (11 warnings)

🐳 ♻️ use distroless for agent-ngt image

Makefile.d/build.mk 50% changes removed in 🐳 ♻️ us...

Makefile.d/docker.mk 44% changes removed in ♻️ add UPX_OP...

🐳 ♻️ use distroless for agent-sidecar image

Makefile.d/build.mk 72% changes removed in 🐳 ♻️ us...

Makefile.d/docker.mk 44% changes removed in ♻️ add UPX_OP...

🐳 ♻️ use distroless for discoverer-k8s image

Makefile.d/build.mk 71% changes removed in 🐳 ♻️ us...

Makefile.d/docker.mk 55% changes removed in ♻️ add UPX_OP...

🐳 ♻️ use distroless for gateway-vald image

Makefile.d/build.mk 71% changes removed in 🐳 ♻️ us...

Makefile.d/docker.mk 56% changes removed in ♻️ add UPX_OP...

🐳 ♻️ use distroless for meta-redis image

Makefile.d/docker.mk 56% changes removed in ♻️ add UPX_OP...

🐳 ♻️ use distroless for meta-cassandra image

Makefile.d/docker.mk 56% changes removed in ♻️ add UPX_OP...

🐳 ♻️ use distroless for manager-backup-mysql image

Makefile.d/docker.mk 56% changes removed in ♻️ add UPX_OP...

🐳 ♻️ use distroless for manager-backup-cassandra image

Makefile.d/docker.mk 56% changes removed in ♻️ add UPX_OP...

🐳 ♻️ use distroless for manager-compressor image

...kers/discoverer/k8s/Dockerfile 50% changes removed in ♻️ add UPX_OP...

...ockers/gateway/vald/Dockerfile 50% changes removed in ♻️ add UPX_OP...

...kers/agent/core/ngt/Dockerfile 50% changes removed in ♻️ add UPX_OP...

...er/backup/cassandra/Dockerfile 50% changes removed in ♻️ add UPX_OP...

...anager/backup/mysql/Dockerfile 50% changes removed in ♻️ add UPX_OP...

...kers/meta/cassandra/Dockerfile 50% changes removed in ♻️ add UPX_OP...

dockers/meta/redis/Dockerfile 50% changes removed in ♻️ add UPX_OP...

Makefile.d/docker.mk 56% changes removed in ♻️ add UPX_OP...

...ckers/agent/sidecar/Dockerfile 50% changes removed in ♻️ add UPX_OP...

🐳 ♻️ use distroless for manager-index image

Makefile.d/docker.mk 56% changes removed in ♻️ add UPX_OP...

♻️ add UPX_OPTIONS

Makefile 50% changes removed in 🐳 ♻️ us...

     🐳 ♻️ use distroless for manager-replication-* image

     🐳 ♻️ use distroless/static:nonroot image

     🐳 💚 add daily trivy scan

     🐳 💚 add release-time trivy scan

     💚 build binaries and publish them to release page

     🔧 show version ad 'pr-xxx' when pr builds

     Revert ":wrench: show version ad 'pr-xxx' when pr builds"

     🔧 show version as 'pr-xxx' when PR builds

     🔧 fix info.BuildTime

     🔧 update go.mod.default

Powered by Pull Assistant. Last update b4294b9 ... 9ed3291. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@rinx rinx force-pushed the refactor/dockers/use-distroless branch from 1c8cb50 to 97d1a33 Compare August 3, 2020 09:26
@rinx rinx force-pushed the refactor/dockers/use-distroless branch 17 times, most recently from ee983fc to 12b86f0 Compare August 7, 2020 00:54
@rinx
Copy link
Contributor Author

rinx commented Aug 11, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by rinx for branch: refactor/dockers/use-distroless

rinx added 21 commits August 11, 2020 08:52
@rinx @actions-user
🐳 ♻️ use distroless for agent-ngt image
b4294b9 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless for agent-sidecar image
acc2bf8 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless for discoverer-k8s image
40cd0ab 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless for gateway-vald image
4193538 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless for meta-redis image
12cf748 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless for meta-cassandra image
0341731 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless for manager-backup-mysql image
15e762a 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless for manager-backup-cassandra image
c74dc68 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless for manager-compressor image
6f4c0d8 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless for manager-index image
dca470f 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
♻️ add UPX_OPTIONS
4f0312d 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless for manager-replication-* image
094cc39 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 ♻️ use distroless/static:nonroot image
8f56701 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 💚 add daily trivy scan
cbaaf1f 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🐳 💚 add release-time trivy scan
a32519c 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
💚 build binaries and publish them to release page
43335c9 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🔧 show version ad 'pr-xxx' when pr builds
4810c63 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
Revert ":wrench: show version ad 'pr-xxx' when pr builds"
671e0da 
This reverts commit 4cd9f3b.
@rinx @actions-user
🔧 show version as 'pr-xxx' when PR builds
c0d15e5 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🔧 fix info.BuildTime
f702ca1 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🔧 update go.mod.default
9ed3291 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the refactor/dockers/use-distroless branch from deb8094 to 9ed3291 Compare August 11, 2020 08:52
kpango
kpango approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango
Copy link
Collaborator

kpango commented Aug 11, 2020

@rinx Is there any problem if I merge this PR?

@rinx
Copy link
Contributor Author

rinx commented Aug 11, 2020

@kpango Thanks for reviewing. There's no problem.

@kpango kpango merged commit 57d657e into master Aug 11, 2020
@kpango kpango deleted the refactor/dockers/use-distroless branch August 11, 2020 09:50
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@kpango kpango kpango approved these changes

Assignees
No one assigned
Labels
area/makefile priority/low size/XXL team/sre SRE team type/ci type/refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rinx @vdaas-ci @kpango