Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test case for internal/kvs/redis/option.go #611

Merged
merged 4 commits into from
Aug 6, 2020

Conversation

hlts2
Copy link
Collaborator

@hlts2 hlts2 commented Aug 4, 2020

Description:

I added test case for internal/kvs/redis/option.go.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Aug 4, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     feat: add test for option

     feat: add comment

     fix: typo

     Update internal/db/kvs/redis/option.go

Powered by Pull Assistant. Last update 6ab00d4 ... e2eee09. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 4, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Aug 4, 2020

Codecov Report

Merging #611 into master will increase coverage by 0.74%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #611      +/-   ##
==========================================
+ Coverage   12.58%   13.32%   +0.74%     
==========================================
  Files         409      409              
  Lines       21341    21341              
==========================================
+ Hits         2685     2844     +159     
+ Misses      18374    18221     -153     
+ Partials      282      276       -6     
Impacted Files Coverage Δ
internal/db/kvs/redis/option.go 100.00% <ø> (+91.42%) ⬆️
internal/worker/queue.go 98.55% <0.00%> (-1.45%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5698abc...e2eee09. Read the comment docs.

kevindiu
kevindiu previously approved these changes Aug 5, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hlts2 hlts2 requested a review from vankichi August 5, 2020 05:53
vankichi
vankichi previously approved these changes Aug 6, 2020
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented Aug 6, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/kvs/redis/option_test

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and kevindiu via cefa5c4 August 6, 2020 01:09
@vdaas-ci vdaas-ci force-pushed the test/internal/kvs/redis/option_test branch from a65bd66 to cefa5c4 Compare August 6, 2020 01:09
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 6, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci previously approved these changes Aug 6, 2020
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>
vankichi
vankichi previously approved these changes Aug 6, 2020
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented Aug 6, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/kvs/redis/option_test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 6, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci previously approved these changes Aug 6, 2020
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>
@hlts2 hlts2 dismissed stale reviews from vdaas-ci and vankichi via e2eee09 August 6, 2020 02:52
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

vankichi commented Aug 6, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 6, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/kvs/redis/option_test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 6, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit b3d5073 into master Aug 6, 2020
@vankichi vankichi deleted the test/internal/kvs/redis/option_test branch August 6, 2020 03:17
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants