Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test of internal/worker/queue_option #613

Merged
merged 3 commits into from
Aug 7, 2020

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Aug 6, 2020

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I added the test of internal/worker/queue_option and comments for each external var/func in internal/queue_option

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Aug 6, 2020

Score: 0.99

Best reviewed: commit by commit


Optimal code review plan

     ✅ Add test of internal/worker/queue_option

     ✅ Update internal/worker/queue_option_test.go

     ✅ Update internal/worker/queue_option_test.go

Powered by Pull Assistant. Last update 3e141d9 ... 4675d2f. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 6, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Aug 6, 2020

Codecov Report

Merging #613 into master will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #613      +/-   ##
==========================================
- Coverage   12.94%   12.94%   -0.01%     
==========================================
  Files         405      405              
  Lines       21294    21294              
==========================================
- Hits         2757     2756       -1     
- Misses      18264    18265       +1     
  Partials      273      273              
Impacted Files Coverage Δ
internal/errgroup/group.go 93.42% <0.00%> (-1.32%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2ee77ce...4675d2f. Read the comment docs.

@vankichi vankichi requested review from hlts2 and kevindiu August 6, 2020 03:10
kevindiu
kevindiu previously approved these changes Aug 6, 2020
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kevindiu
kevindiu previously approved these changes Aug 6, 2020
hlts2
hlts2 previously approved these changes Aug 6, 2020
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor Author

vankichi commented Aug 7, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 7, 2020

[REBASE] Rebase triggered by vankichi for branch: test/internal/worker_queue_option_test

vankichi and others added 3 commits August 7, 2020 01:38
Signed-off-by: vankichi <kyukawa315@gmail.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
@vdaas-ci vdaas-ci dismissed stale reviews from hlts2 and kevindiu via 4675d2f August 7, 2020 01:38
@vdaas-ci vdaas-ci force-pushed the test/internal/worker_queue_option_test branch from 3dcab03 to 4675d2f Compare August 7, 2020 01:38
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 7, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit d4fa50b into master Aug 7, 2020
@vankichi vankichi deleted the test/internal/worker_queue_option_test branch August 7, 2020 01:57
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants