Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix internal/worker testing fail #616

Merged
merged 1 commit into from
Aug 7, 2020
Merged

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Aug 7, 2020

Description:

This PR fix the internal/worker package testing fail due to the same var named in the same package.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Aug 7, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     fix test fail

Powered by Pull Assistant. Last update ead3df2 ... ead3df2. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 7, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Aug 7, 2020

Codecov Report

Merging #616 into master will increase coverage by 0.77%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #616      +/-   ##
==========================================
+ Coverage   12.94%   13.72%   +0.77%     
==========================================
  Files         405      409       +4     
  Lines       21294    21516     +222     
==========================================
+ Hits         2757     2953     +196     
- Misses      18264    18284      +20     
- Partials      273      279       +6     
Impacted Files Coverage Δ
internal/worker/worker_option.go 62.50% <0.00%> (ø)
internal/worker/queue.go 100.00% <0.00%> (ø)
internal/worker/queue_option.go 89.47% <0.00%> (ø)
internal/worker/worker.go 86.36% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4fa50b...ead3df2. Read the comment docs.

hlts2
hlts2 previously approved these changes Aug 7, 2020
Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you
LGTM

@kevindiu kevindiu requested a review from vankichi August 7, 2020 01:51
vankichi
vankichi previously approved these changes Aug 7, 2020
@vankichi
Copy link
Contributor

vankichi commented Aug 7, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 7, 2020

[REBASE] Rebase triggered by vankichi for branch: fix/internal/worker/ci

@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and hlts2 via ead3df2 August 7, 2020 02:02
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Aug 7, 2020

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit a09c1fe into master Aug 7, 2020
@vankichi vankichi deleted the fix/internal/worker/ci branch August 7, 2020 02:22
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants