Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add internal/compress/lz4_option test #619

Merged
merged 4 commits into from
Aug 11, 2020
Merged

add internal/compress/lz4_option test #619

merged 4 commits into from
Aug 11, 2020

Conversation

vankichi
Copy link
Contributor

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

  • Add test for internal/compress/lz4_option

  • Update comments for each external func/method/var in internal/compress/lz4_option

  • Note: I could not cover the error pattern test in WithLZ4Gob, because gobCompressor is an empty struct and has no options.

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vankichi
✅ add internal/compress/lz4_option test
d6bb181 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi self-assigned this Aug 11, 2020
@pull-assistant
Copy link

pull-assistant bot commented Aug 11, 2020 •
edited
Loading

Score: 0.74

Best reviewed: commit by commit

Optimal code review plan

     ✅ add internal/compress/lz4_option test

     ✅ fix

     ✅ fix

     ✅ revert

Powered by Pull Assistant. Last update d6bb181 ... c07819c. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@codecov
Copy link

codecov bot commented Aug 11, 2020 •
edited
Loading

Codecov Report

Merging #619 into master will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #619   +/-   ##
=======================================
  Coverage   13.72%   13.72%           
=======================================
  Files         409      409           
  Lines       21516    21516           
=======================================
+ Hits         2953     2954    +1     
  Misses      18286    18286           
+ Partials      277      276    -1
Impacted Files Coverage Δ
internal/compress/lz4_option.go 84.61% <ø> (+15.38%) ⬆️
internal/errgroup/group.go 93.42% <0.00%> (-1.32%) ⬇️
internal/worker/worker.go 84.54% <0.00%> (-0.91%) ⬇️
internal/worker/queue.go 100.00% <0.00%> (+1.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a09c1fe...c07819c. Read the comment docs.

@vankichi
✅ fix
b251124 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi
✅ fix
8e40875 
Signed-off-by: vankichi <kyukawa315@gmail.com>
hlts2
hlts2 previously approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

kevindiu
kevindiu previously approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor Author

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/compress_lz4_option

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci previously approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi
✅ revert
c07819c 
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vankichi vankichi dismissed stale reviews from vdaas-ci, kevindiu, and hlts2 via c07819c August 11, 2020 05:20
kevindiu
kevindiu approved these changes Aug 11, 2020
View reviewed changes
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hlts2
hlts2 approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor Author

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/compress_lz4_option

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci approved these changes Aug 11, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 598d0cc into master Aug 11, 2020
@vankichi vankichi deleted the test/internal/compress_lz4_option branch August 11, 2020 06:20
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
Merged
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@hlts2 hlts2 hlts2 approved these changes

@kevindiu kevindiu kevindiu approved these changes

Assignees

@vankichi vankichi

Labels
area/internal priority/low size/L team/set SET team type/test Adding tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@vankichi @vdaas-ci @kevindiu @hlts2