Add devcontainer #620

rinx · 2020-08-11T07:55:07Z

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

To enable GitHub Codespaces, I added .devcontainer/devcontainer.json & dockers/dev/Dockerfile.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

Go Version: 1.14.4
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.0

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci] ?

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

pull-assistant · 2020-08-11T07:55:10Z

Best reviewed: commit by commit

Optimal code review plan (1 warning)

🐳 🔧 Add devcontainer

dockers/dev/Dockerfile 68% changes removed in 🐳 🔧 Rev...

🐳 🔧 Add devcontainer CI

🐳 🔧 Revise devcontainer base

Powered by Pull Assistant. Last update 5b0f50f ... 6192d2f. Read the comment docs.

vdaas-ci · 2020-08-11T07:55:23Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

github-actions · 2020-08-11T07:55:43Z

dockers/dev/Dockerfile

+# limitations under the License.
+#
+
+FROM vdaas/vald-ci-container:latest AS builder


[hadolint] _{reported by reviewdog 🐶}
DL3007 Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag

github-actions · 2020-08-11T07:55:44Z

dockers/dev/Dockerfile

+
+ENV PATH=$PATH:$GOROOT/bin
+
+RUN apt-get update && apt-get install -y --no-install-recommends \


[hadolint] _{reported by reviewdog 🐶}
DL3008 Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

rinx · 2020-08-11T07:56:44Z

.devcontainer/devcontainer.json

+    "go.testOnSave": true,
+    "go.gopath": "/go"
+  },
+  "extensions": [


@kmrmt Do you have any recommends of extensions for Go development in VSCode?

kmrmt

LGTM

github-actions · 2020-08-27T10:16:30Z

dockers/dev/Dockerfile

+# limitations under the License.
+#
+
+FROM vdaas/vald-ci-container:latest AS vald


[hadolint] _{reported by reviewdog 🐶}
DL3007 Using latest is prone to errors if the image will ever update. Pin the version explicitly to a release tag

rinx · 2020-09-23T03:15:06Z

@kmrmt @kpango @vankichi Now it's ready to use. Please try it on your Codespaces and approve if it's okay.

kpango

LGTM

kpango · 2020-09-23T23:57:00Z

@kmrmt @vankichi could you please review VSCode settings? I'm not good at VSCode cus I'm Vimmer.
I'd appreciate if you could review.

vankichi · 2020-09-24T05:44:27Z

@kpango @rinx
Unfortunately, I'm not good at VSCode 😅
But I tried to apply .devcontainer/devcontainer.jon to my local VSCode, it looks good for me.
IMO, LGTM about this setting 👍

kpango · 2020-09-24T05:46:13Z

seems 2 approvals I think it's okay to merge.
/rebase
/format
/approve

vdaas-ci · 2020-09-24T05:46:47Z

[REBASE] Rebase triggered by kpango for branch: ci/devenv/add-codespace-and-devcontainer

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

vdaas-ci · 2020-09-24T05:47:42Z

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

vdaas-ci

[APPROVED] This PR is approved by kpango.

rinx requested a review from kmrmt August 11, 2020 07:55

github-actions bot added size/L type/ci labels Aug 11, 2020

github-actions bot reviewed Aug 11, 2020

View reviewed changes

github-actions bot added the priority/low label Aug 11, 2020

rinx commented Aug 11, 2020

View reviewed changes

github-actions bot added area/makefile team/sre SRE team labels Aug 11, 2020

rinx force-pushed the ci/devenv/add-codespace-and-devcontainer branch 2 times, most recently from b164bfb to 0fb58e1 Compare August 11, 2020 10:00

kmrmt approved these changes Aug 12, 2020

View reviewed changes

kmrmt previously approved these changes Aug 12, 2020

View reviewed changes

rinx dismissed kmrmt’s stale review via fabb22a August 27, 2020 10:14

github-actions bot added size/M and removed size/M labels Aug 27, 2020

github-actions bot reviewed Aug 27, 2020

View reviewed changes

rinx force-pushed the ci/devenv/add-codespace-and-devcontainer branch from fabb22a to 6670beb Compare September 23, 2020 02:42

github-actions bot added size/M and removed size/M labels Sep 23, 2020

rinx added size/M and removed size/L labels Sep 23, 2020

rinx marked this pull request as ready for review September 23, 2020 03:13

rinx requested review from kpango and vankichi September 23, 2020 03:13

kpango previously approved these changes Sep 23, 2020

View reviewed changes

vankichi previously approved these changes Sep 24, 2020

View reviewed changes

rinx added 3 commits September 24, 2020 05:46

🐳 🔧 Add devcontainer

5b0f50f

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🐳 🔧 Add devcontainer CI

9d31a14

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🐳 🔧 Revise devcontainer base

6192d2f

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

vdaas-ci dismissed stale reviews from vankichi and kpango via 6192d2f September 24, 2020 05:46

vdaas-ci force-pushed the ci/devenv/add-codespace-and-devcontainer branch from 6670beb to 6192d2f Compare September 24, 2020 05:46

vdaas-ci approved these changes Sep 24, 2020

View reviewed changes

kpango merged commit dd60c10 into master Sep 24, 2020

kpango deleted the ci/devenv/add-codespace-and-devcontainer branch September 24, 2020 05:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add devcontainer #620

Add devcontainer #620

rinx commented Aug 11, 2020

pull-assistant bot commented Aug 11, 2020 •

edited

Loading

vdaas-ci commented Aug 11, 2020

github-actions bot Aug 11, 2020

github-actions bot Aug 11, 2020

rinx Aug 11, 2020

kmrmt Aug 11, 2020

kmrmt left a comment

github-actions bot Aug 27, 2020

rinx commented Sep 23, 2020

kpango left a comment

kpango commented Sep 23, 2020

vankichi commented Sep 24, 2020 •

edited

Loading

kpango commented Sep 24, 2020

vdaas-ci commented Sep 24, 2020

vdaas-ci commented Sep 24, 2020

vdaas-ci left a comment


		ENV PATH=$PATH:$GOROOT/bin

		RUN apt-get update && apt-get install -y --no-install-recommends \

Add devcontainer #620

Add devcontainer #620

Conversation

rinx commented Aug 11, 2020

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Aug 11, 2020 • edited Loading

vdaas-ci commented Aug 11, 2020

github-actions bot Aug 11, 2020

Choose a reason for hiding this comment

github-actions bot Aug 11, 2020

Choose a reason for hiding this comment

rinx Aug 11, 2020

Choose a reason for hiding this comment

kmrmt Aug 11, 2020

Choose a reason for hiding this comment

kmrmt left a comment

Choose a reason for hiding this comment

github-actions bot Aug 27, 2020

Choose a reason for hiding this comment

rinx commented Sep 23, 2020

kpango left a comment

Choose a reason for hiding this comment

kpango commented Sep 23, 2020

vankichi commented Sep 24, 2020 • edited Loading

kpango commented Sep 24, 2020

vdaas-ci commented Sep 24, 2020

vdaas-ci commented Sep 24, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

pull-assistant bot commented Aug 11, 2020 •

edited

Loading

vankichi commented Sep 24, 2020 •

edited

Loading