Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add internal/db/rdb/mysql/option test #626

Merged
merged 5 commits into from
Aug 14, 2020
Merged

add internal/db/rdb/mysql/option test #626

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
28dbaa8
:white_check_mark: add internal/db/rdb/mysql/option test
vankichi Aug 13, 2020
56b7668
Update internal/db/rdb/mysql/option_test.go
vankichi Aug 13, 2020
abe0d31
Update internal/db/rdb/mysql/option_test.go
vankichi Aug 13, 2020
b5dc446
Update internal/db/rdb/mysql/option_test.go
vankichi Aug 13, 2020
0999765
:robot: Update license headers / Format go codes and yaml files
vdaas-ci Aug 13, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions internal/db/rdb/mysql/option.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,7 @@ import (
"github.com/vdaas/vald/internal/timeutil"
)

// Option represents the functional option for mySQLClient.
type Option func(*mySQLClient) error

var (
Expand All @@ -39,6 +40,7 @@ var (
}
)

// WithTimezone returns the option to set the timezone.
func WithTimezone(tz string) Option {
return func(m *mySQLClient) error {
if tz != "" {
Expand All @@ -48,6 +50,7 @@ func WithTimezone(tz string) Option {
}
}

// WithCharset returns the option to set the charset.
func WithCharset(cs string) Option {
return func(m *mySQLClient) error {
if cs != "" {
Expand All @@ -57,6 +60,7 @@ func WithCharset(cs string) Option {
}
}

// WithDB returns the option to set the db.
func WithDB(db string) Option {
return func(m *mySQLClient) error {
if db != "" {
Expand All @@ -66,6 +70,7 @@ func WithDB(db string) Option {
}
}

// WithHost returns the option to set the host.
func WithHost(host string) Option {
return func(m *mySQLClient) error {
if host != "" {
Expand All @@ -75,13 +80,15 @@ func WithHost(host string) Option {
}
}

// WithPort returns the option to set the port.
func WithPort(port int) Option {
return func(m *mySQLClient) error {
m.port = port
return nil
}
}

// WithUser returns the option to set the user.
func WithUser(user string) Option {
return func(m *mySQLClient) error {
if user != "" {
Expand All @@ -91,6 +98,7 @@ func WithUser(user string) Option {
}
}

// WithPass returns the option to set the pass.
func WithPass(pass string) Option {
return func(m *mySQLClient) error {
if pass != "" {
Expand All @@ -100,6 +108,7 @@ func WithPass(pass string) Option {
}
}

// WithName returns the option to sst the name.
func WithName(name string) Option {
return func(m *mySQLClient) error {
if name != "" {
Expand All @@ -109,6 +118,7 @@ func WithName(name string) Option {
}
}

// WithInitialPingTimeLimit returns the option to set the initialPingTimeLimit.
func WithInitialPingTimeLimit(lim string) Option {
return func(m *mySQLClient) error {
if lim == "" {
Expand All @@ -123,6 +133,7 @@ func WithInitialPingTimeLimit(lim string) Option {
}
}

// WithInitialPingDuration returns the option to set the initialPingDuration.
func WithInitialPingDuration(dur string) Option {
return func(m *mySQLClient) error {
if dur == "" {
Expand All @@ -137,6 +148,7 @@ func WithInitialPingDuration(dur string) Option {
}
}

// WithConnectionLifeTimeLimit returns the option to set the connMaxLifeTime.
func WithConnectionLifeTimeLimit(dur string) Option {
return func(m *mySQLClient) error {
if dur == "" {
Expand All @@ -151,6 +163,9 @@ func WithConnectionLifeTimeLimit(dur string) Option {
}
}

// WithMaxIdleConns returns the option to set the maxIdleConns.
// If conns is negative numner, no idle connections are retained.
// ref: https://golang.org/src/database/sql/sql.go?s=24983:25019#L879
func WithMaxIdleConns(conns int) Option {
return func(m *mySQLClient) error {
if conns != 0 {
Expand All @@ -160,6 +175,9 @@ func WithMaxIdleConns(conns int) Option {
}
}

// WithMaxOpenConns returns the option to set the maxOpenConns.
// If conns is negative numner, no limit on the number of open connections.
// ref: https://golang.org/src/database/sql/sql.go?s=24983:25019#L923
func WithMaxOpenConns(conns int) Option {
return func(m *mySQLClient) error {
if conns != 0 {
Expand All @@ -169,6 +187,7 @@ func WithMaxOpenConns(conns int) Option {
}
}

// WithTLSConfig returns the option to set the tlsConfig.
func WithTLSConfig(cfg *tls.Config) Option {
return func(m *mySQLClient) error {
if cfg != nil {
Expand All @@ -178,6 +197,7 @@ func WithTLSConfig(cfg *tls.Config) Option {
}
}

// WithDialer returns the option to set the dialer.
func WithDialer(der func(ctx context.Context, addr, port string) (net.Conn, error)) Option {
return func(m *mySQLClient) error {
if der != nil {
Expand Down
Loading