Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade go mod default: k8s.io/xxx v0.18.8 #645

Merged
merged 6 commits into from
Aug 27, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Aug 27, 2020

Description:

Upgraded k8s libs to v0.18.8.
(also added k8s.io/metrics lib)

Fixed Makefile: compatible with macOS.

Related Issue:

Nothing.

How Has This Been Tested?:

Nothing.

Environment:

  • Go Version: 1.14.4
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.0

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Aug 27, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     ⬆️ use k8s.io/* v0.18.8

     ⬆️ update go.mod, go.sum

     🐛 fix pre-commit hook

     🐛 fix Makefile: compatible with macOS

     💚 run builds and tests when go.mod and go.sum updated

     ✅ fix tests: internal/version

Powered by Pull Assistant. Last update 84aa081 ... c328e20. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@rinx
Copy link
Contributor Author

rinx commented Aug 27, 2020

/rebase
/format

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by rinx for branch: dependencies/upgrade-go-mod-default

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the dependencies/upgrade-go-mod-default branch from 2d1df24 to 51ce757 Compare August 27, 2020 04:47
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by rinx.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx marked this pull request as ready for review August 27, 2020 05:50
@codecov
Copy link

codecov bot commented Aug 27, 2020

Codecov Report

Merging #645 into master will increase coverage by 3.15%.
The diff coverage is 67.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #645      +/-   ##
==========================================
+ Coverage   12.19%   15.35%   +3.15%     
==========================================
  Files         409      412       +3     
  Lines       21340    21600     +260     
==========================================
+ Hits         2602     3316     +714     
+ Misses      18454    18027     -427     
+ Partials      284      257      -27     
Impacted Files Coverage Δ
internal/compress/gzip_option.go 84.61% <ø> (+15.38%) ⬆️
internal/compress/lz4_option.go 84.61% <ø> (+15.38%) ⬆️
internal/config/mysql.go 43.47% <0.00%> (-56.53%) ⬇️
internal/config/redis.go 0.00% <0.00%> (ø)
internal/db/rdb/mysql/mysql.go 0.00% <0.00%> (ø)
internal/errors/net.go 0.00% <ø> (ø)
internal/info/info.go 29.16% <ø> (ø)
internal/observability/trace/trace.go 0.00% <ø> (ø)
internal/worker/queue_option.go 100.00% <ø> (+84.21%) ⬆️
pkg/manager/backup/mysql/service/mysql.go 0.00% <ø> (ø)
... and 58 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cfcf27a...c328e20. Read the comment docs.

@rinx rinx requested review from kpango, hlts2 and kmrmt August 27, 2020 06:11
@kpango kpango merged commit 99a0b9e into master Aug 27, 2020
@kpango kpango deleted the dependencies/upgrade-go-mod-default branch August 27, 2020 06:35
@vdaas-ci vdaas-ci mentioned this pull request Sep 2, 2020
18 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants