Implement zstd test #676

kevindiu · 2020-09-07T07:19:14Z

Description:

This PR includes the implementation of compress/zstd.go test cases.
It also include the changes to use the aliased object instead of the zstd package one, for example:

NewWriter(w io.Writer, opts ...zstd.EOption) (Encoder, error)
                            |
                            v
NewWriter(w io.Writer, opts ...EOption) (Encoder, error)

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.1
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

kevindiu · 2020-09-07T07:19:24Z

/rebase

vdaas-ci · 2020-09-07T07:19:32Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

pull-assistant · 2020-09-07T07:19:35Z

Best reviewed: commit by commit

Optimal code review plan

implement zstd test

add comment

remove unused code and fix e2e test

Powered by Pull Assistant. Last update 415726b ... 2f7a48b. Read the comment docs.

vdaas-ci · 2020-09-07T07:20:08Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/compress/zstd.go

codecov · 2020-09-07T07:26:09Z

Codecov Report

Merging #676 into master will increase coverage by 0.19%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #676      +/-   ##
==========================================
+ Coverage   15.36%   15.55%   +0.19%     
==========================================
  Files         412      412              
  Lines       21626    21626              
==========================================
+ Hits         3322     3365      +43     
+ Misses      18056    18021      -35     
+ Partials      248      240       -8

Impacted Files	Coverage Δ
internal/compress/zstd.go	`100.00% <ø> (+69.35%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dc3563d...2f7a48b. Read the comment docs.

internal/compress/zstd_test.go

hlts2 · 2020-09-07T08:47:30Z

@kevindiu

thank you for your pr.
could you please fix e2e test to match the test template?

kevindiu · 2020-09-07T09:30:38Z

/format

vdaas-ci · 2020-09-07T09:32:00Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

vdaas-ci · 2020-09-07T09:32:36Z

[FORMAT] Failed to format.

hlts2

LGTM

internal/compress/zstd/zstd.go

vankichi · 2020-09-10T02:51:42Z

/rebase
/format
/approve

vdaas-ci · 2020-09-10T02:52:18Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/compress/zstd.go

vdaas-ci · 2020-09-10T02:52:23Z

[REBASE] Failed to rebase.

github-actions · 2020-09-10T02:58:45Z

internal/compress/zstd_test.go

-			if tc.vector[i] != decompressed[i] {
-				t.Fatalf("Invalid convert: origin %+v, compressed -> decompressed %+v", tc.vector, decompressed)
+var (
+	zstdCompressorComparatorOptions = []comparator.Option{


[golangci] _{reported by reviewdog 🐶}
zstdCompressorComparatorOptions is a global variable (gochecknoglobals)

vankichi · 2020-09-10T04:45:02Z

/rebase
/format
/approve

vdaas-ci · 2020-09-10T04:45:39Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/compress/zstd.go

vdaas-ci · 2020-09-10T04:45:43Z

[REBASE] Failed to rebase.

vankichi · 2020-09-10T05:21:32Z

/rebase
/format
/approve

vdaas-ci · 2020-09-10T05:22:07Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/compress/zstd.go

vdaas-ci · 2020-09-10T05:22:57Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

kevindiu requested a review from hlts2 September 7, 2020 07:19

github-actions bot added area/internal team/set SET team size/XL type/test Adding tests priority/low labels Sep 7, 2020

vdaas-ci force-pushed the test/internal/compress/zstd.go branch from 479dcef to 3900e7a Compare September 7, 2020 07:20

hlts2 reviewed Sep 7, 2020

View reviewed changes

internal/compress/zstd_test.go Outdated Show resolved Hide resolved

hlts2 reviewed Sep 7, 2020

View reviewed changes

internal/compress/zstd_test.go Outdated Show resolved Hide resolved

kevindiu requested a review from hlts2 September 7, 2020 09:30

hlts2 previously approved these changes Sep 7, 2020

View reviewed changes

kevindiu requested a review from vankichi September 7, 2020 09:44

vankichi reviewed Sep 9, 2020

View reviewed changes

internal/compress/zstd/zstd.go Show resolved Hide resolved

vankichi previously approved these changes Sep 10, 2020

View reviewed changes

github-actions bot reviewed Sep 10, 2020

View reviewed changes

kevindiu added 3 commits September 10, 2020 13:54

implement zstd test

415726b

add comment

95d97d6

remove unused code and fix e2e test

2f7a48b

kevindiu dismissed stale reviews from vankichi and hlts2 via 2f7a48b September 10, 2020 04:54

kevindiu force-pushed the test/internal/compress/zstd.go branch from b313b72 to 2f7a48b Compare September 10, 2020 04:54

vdaas-ci approved these changes Sep 10, 2020

View reviewed changes

vankichi merged commit b7bc99a into master Sep 10, 2020

vankichi deleted the test/internal/compress/zstd.go branch September 10, 2020 09:21

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement zstd test #676

Implement zstd test #676

kevindiu commented Sep 7, 2020 •

edited

Loading

kevindiu commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

pull-assistant bot commented Sep 7, 2020 •

edited

Loading

vdaas-ci commented Sep 7, 2020

codecov bot commented Sep 7, 2020 •

edited

Loading

hlts2 commented Sep 7, 2020

kevindiu commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

hlts2 left a comment

vankichi commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

github-actions bot Sep 10, 2020

vankichi commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

vankichi commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

vdaas-ci left a comment

Implement zstd test #676

Implement zstd test #676

Conversation

kevindiu commented Sep 7, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

kevindiu commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

pull-assistant bot commented Sep 7, 2020 • edited Loading

vdaas-ci commented Sep 7, 2020

codecov bot commented Sep 7, 2020 • edited Loading

Codecov Report

hlts2 commented Sep 7, 2020

kevindiu commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

vdaas-ci commented Sep 7, 2020

hlts2 left a comment

Choose a reason for hiding this comment

vankichi commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

github-actions bot Sep 10, 2020

Choose a reason for hiding this comment

vankichi commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

vankichi commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

vdaas-ci commented Sep 10, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

kevindiu commented Sep 7, 2020 •

edited

Loading

pull-assistant bot commented Sep 7, 2020 •

edited

Loading

codecov bot commented Sep 7, 2020 •

edited

Loading