[patch] remove cockroachdb/errors #677

kpango · 2020-09-07T09:45:34Z

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Description:

remove cockroachdb/errors for license problem

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.1
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

pull-assistant · 2020-09-07T09:45:55Z

Best reviewed: commit by commit

Optimal code review plan (1 warning)

[patch] remove cockroachdb/errors

internal/errors/errors.go 50% changes removed in fix deepsource go

change error message format

fix deepsource go

Powered by Pull Assistant. Last update d23ea5a ... d79b6b4. Read the comment docs.

vdaas-ci · 2020-09-07T09:45:57Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

rinx

LGTM

hlts2

LGTM

github-actions · 2020-09-07T09:51:21Z

internal/errors/errors.go

 		}
 		return nil
 	}

+	Unwrap = func(err error) error {


[golangci] _{reported by reviewdog 🐶}
Unwrap is a global variable (gochecknoglobals)

github-actions · 2020-09-07T09:51:21Z

internal/errors/errors.go

-	Is         = errors.Is
-	UnWrapOnce = errbase.UnwrapOnce
-	UnWrapAll  = errbase.UnwrapAll
+	As = errors.As


[golangci] _{reported by reviewdog 🐶}
As is a global variable (gochecknoglobals)

github-actions · 2020-09-07T09:51:21Z

internal/errors/errors.go

-	UnWrapOnce = errbase.UnwrapOnce
-	UnWrapAll  = errbase.UnwrapAll
+	As = errors.As
+	Is = errors.Is


[golangci] _{reported by reviewdog 🐶}
Is is a global variable (gochecknoglobals)

codecov · 2020-09-07T09:51:43Z

Codecov Report

Merging #677 into master will increase coverage by 0.21%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##           master     #677      +/-   ##
==========================================
+ Coverage   15.38%   15.60%   +0.21%     
==========================================
  Files         412      413       +1     
  Lines       21598    21660      +62     
==========================================
+ Hits         3323     3379      +56     
- Misses      18027    18030       +3     
- Partials      248      251       +3

Impacted Files	Coverage Δ
internal/errors/blob.go	`0.00% <0.00%> (ø)`
internal/errors/cassandra.go	`0.00% <0.00%> (ø)`
internal/errors/errors.go	`3.44% <0.00%> (-1.21%)`	⬇️
internal/errors/mysql.go	`0.00% <0.00%> (ø)`
internal/errors/redis.go	`0.00% <0.00%> (ø)`
...g/manager/backup/cassandra/handler/grpc/handler.go	`0.00% <ø> (ø)`
pkg/manager/backup/mysql/handler/grpc/handler.go	`0.00% <ø> (ø)`
internal/net/net.go	`87.30% <0.00%> (ø)`
internal/worker/worker.go	`85.45% <0.00%> (+0.90%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 755d9c0...d79b6b4. Read the comment docs.

github-actions · 2020-09-07T10:47:11Z

internal/errors/errors.go

 		}
 		return nil
 	}

+	Unwrap = func(err error) error {


[golangci] _{reported by reviewdog 🐶}
unlambda: replace `func(err error) error {

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

github-actions · 2020-09-07T11:29:44Z

internal/errors/errors.go

-	Is         = errors.Is
-	UnWrapOnce = errbase.UnwrapOnce
-	UnWrapAll  = errbase.UnwrapAll
+	Is = func(err, target error) bool {


[golangci] _{reported by reviewdog 🐶}
Is is a global variable (gochecknoglobals)

github-actions · 2020-09-07T11:29:45Z

internal/info/info_test.go

@@ -101,7 +101,7 @@ func TestGet(t *testing.T) {
 	}
 	defaultCheckFunc := func(w want, got Detail) error {
 		if !reflect.DeepEqual(got, w.want) {
-			return errors.Errorf("got = %v, want %v", got, w.want)
+			return errors.Errorf("got: \"%#v\",\n\t\t\t\twant: \"%#v\"", got, w.want)


[golangci] _{reported by reviewdog 🐶}
copylocks: call of errors.Errorf copies lock value: github.com/vdaas/vald/internal/info.Detail contains sync.Once contains sync.Mutex (govet)

github-actions · 2020-09-07T11:29:45Z

internal/info/info_test.go

@@ -293,7 +293,7 @@ func TestDetail_Get(t *testing.T) {
 	}
 	defaultCheckFunc := func(w want, got Detail) error {
 		if !reflect.DeepEqual(got, w.want) {
-			return errors.Errorf("got = %v, want %v", got, w.want)
+			return errors.Errorf("got: \"%#v\",\n\t\t\t\twant: \"%#v\"", got, w.want)


[golangci] _{reported by reviewdog 🐶}
copylocks: call of errors.Errorf copies lock value: github.com/vdaas/vald/internal/info.Detail contains sync.Once contains sync.Mutex (govet)

github-actions · 2020-09-07T14:38:40Z

internal/errors/errors.go

 		}
 		return nil
 	}

+	Unwrap = func(err error) error { return errors.Unwrap(err) }


[golangci] _{reported by reviewdog 🐶}
unlambda: replace func(err error) error { return errors.Unwrap(err) } with errors.Unwrap (gocritic)

vdaas-ci · 2020-09-07T14:56:09Z

[WARNING:INTCFG] Changes in interal/config may require you to change Helm charts. Please check.

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

kpango · 2020-09-08T02:06:57Z

@rinx @hlts2 I passed all test code and deep source.
I changed errors/errors.go's Is function & test comparator error message format.
Others no changes from yesterday you reviewed, would you mind if I merge this PR?

rinx · 2020-09-08T02:30:40Z

apis/swagger/agent/core/core/agent.swagger.json

@@ -349,8 +349,7 @@
          "format": "int64"
        },
        "indexing": {
-          "type": "boolean",
-          "format": "boolean"


why these swagger files updated?

don't know, I just run make update for dependencies update.
may be swagger version ?

I checked swagger specification, there is not format field for boolean type.
maybe old version has format for boolean type.
FYI: https://swagger.io/specification/#data-types

@rinx (mention for FYI) and I'll merge this PR

[patch] remove cockroachdb/errors

d23ea5a

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

github-actions bot added area/internal area/makefile area/manager/backup area/meta team/sre SRE team size/L type/feature New feature priority/medium labels Sep 7, 2020

rinx previously approved these changes Sep 7, 2020

View reviewed changes

hlts2 previously approved these changes Sep 7, 2020

View reviewed changes

github-actions bot reviewed Sep 7, 2020

View reviewed changes

kpango dismissed stale reviews from hlts2 and rinx via 39b09d3 September 7, 2020 10:41

github-actions bot added team/set SET team size/XXXL and removed size/L labels Sep 7, 2020

github-actions bot reviewed Sep 7, 2020

View reviewed changes

kpango force-pushed the feature/internal/remove-cockroachdb-errors branch from 39b09d3 to ecfa457 Compare September 7, 2020 11:17

change error message format

74920f0

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

kpango force-pushed the feature/internal/remove-cockroachdb-errors branch from ecfa457 to 74920f0 Compare September 7, 2020 11:24

github-actions bot reviewed Sep 7, 2020

View reviewed changes

kpango force-pushed the feature/internal/remove-cockroachdb-errors branch from 6a11eb5 to 7342ba4 Compare September 7, 2020 14:55

github-actions bot added area/agent/core area/agent/sidecar labels Sep 7, 2020

github-actions bot added area/discoverer area/filter/egress area/filter/ingress area/gateway area/manager/index area/manager/replication area/tools/cli/loadtest labels Sep 7, 2020

kpango force-pushed the feature/internal/remove-cockroachdb-errors branch from 7342ba4 to 5a42815 Compare September 7, 2020 14:56

fix deepsource go

d79b6b4

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

kpango force-pushed the feature/internal/remove-cockroachdb-errors branch from 5a42815 to d79b6b4 Compare September 7, 2020 15:19

rinx reviewed Sep 8, 2020

View reviewed changes

rinx approved these changes Sep 8, 2020

View reviewed changes

kpango merged commit 2b3c7f7 into master Sep 8, 2020

kpango deleted the feature/internal/remove-cockroachdb-errors branch September 8, 2020 02:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[patch] remove cockroachdb/errors #677

[patch] remove cockroachdb/errors #677

kpango commented Sep 7, 2020 •

edited

Loading

pull-assistant bot commented Sep 7, 2020 •

edited

Loading

vdaas-ci commented Sep 7, 2020

rinx left a comment

hlts2 left a comment

github-actions bot Sep 7, 2020

github-actions bot Sep 7, 2020

github-actions bot Sep 7, 2020

codecov bot commented Sep 7, 2020 •

edited

Loading

github-actions bot Sep 7, 2020

github-actions bot Sep 7, 2020

github-actions bot Sep 7, 2020

github-actions bot Sep 7, 2020

github-actions bot Sep 7, 2020

vdaas-ci commented Sep 7, 2020

kpango commented Sep 8, 2020

rinx Sep 8, 2020

kpango Sep 8, 2020

rinx Sep 8, 2020

kpango Sep 8, 2020

kpango Sep 8, 2020

[patch] remove cockroachdb/errors #677

[patch] remove cockroachdb/errors #677

Conversation

kpango commented Sep 7, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Sep 7, 2020 • edited Loading

vdaas-ci commented Sep 7, 2020

rinx left a comment

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

github-actions bot Sep 7, 2020

Choose a reason for hiding this comment

github-actions bot Sep 7, 2020

Choose a reason for hiding this comment

github-actions bot Sep 7, 2020

Choose a reason for hiding this comment

codecov bot commented Sep 7, 2020 • edited Loading

Codecov Report

github-actions bot Sep 7, 2020

Choose a reason for hiding this comment

github-actions bot Sep 7, 2020

Choose a reason for hiding this comment

github-actions bot Sep 7, 2020

Choose a reason for hiding this comment

github-actions bot Sep 7, 2020

Choose a reason for hiding this comment

github-actions bot Sep 7, 2020

Choose a reason for hiding this comment

vdaas-ci commented Sep 7, 2020

kpango commented Sep 8, 2020

rinx Sep 8, 2020

Choose a reason for hiding this comment

kpango Sep 8, 2020

Choose a reason for hiding this comment

rinx Sep 8, 2020

Choose a reason for hiding this comment

kpango Sep 8, 2020

Choose a reason for hiding this comment

kpango Sep 8, 2020

Choose a reason for hiding this comment

kpango commented Sep 7, 2020 •

edited

Loading

pull-assistant bot commented Sep 7, 2020 •

edited

Loading

codecov bot commented Sep 7, 2020 •

edited

Loading