[patch] bugfix error assertion #680

kpango · 2020-09-08T04:26:33Z

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.1
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

pull-assistant · 2020-09-08T04:26:35Z

Best reviewed: commit by commit

Optimal code review plan (1 warning)

[patch] bugfix error assertion

internal/errors/blob.go 50% changes removed in Merge branch 'master...

internal/errors/cassandra.go 50% changes removed in Merge branch 'master...

internal/errors/mysql.go 50% changes removed in Merge branch 'master...

internal/errors/redis.go 50% changes removed in Merge branch 'master...

Merge branch 'master' into bugfix/internal-errors/DB-IsXXXX-function-e...

fix

🤖 Update license headers / Format go codes and yaml files

Powered by Pull Assistant. Last update a26faa2 ... d7d999b. Read the comment docs.

vdaas-ci · 2020-09-08T04:26:50Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

codecov · 2020-09-08T04:33:02Z

Codecov Report

Merging #680 into master will increase coverage by 0.44%.
The diff coverage is 35.36%.

@@            Coverage Diff             @@
##           master     #680      +/-   ##
==========================================
+ Coverage   15.13%   15.58%   +0.44%     
==========================================
  Files         411      413       +2     
  Lines       21537    21667     +130     
==========================================
+ Hits         3259     3376     +117     
- Misses      18024    18039      +15     
+ Partials      254      252       -2

Impacted Files	Coverage Δ
internal/db/storage/blob/s3/writer/writer.go	`0.00% <0.00%> (ø)`
internal/errors/blob.go	`0.00% <0.00%> (ø)`
internal/errors/cassandra.go	`0.00% <0.00%> (ø)`
internal/errors/errors.go	`3.44% <0.00%> (-1.21%)`	⬇️
internal/errors/mysql.go	`0.00% <0.00%> (ø)`
internal/errors/option.go	`0.00% <0.00%> (ø)`
internal/errors/redis.go	`0.00% <0.00%> (ø)`
internal/observability/metrics/metrics.go	`0.00% <ø> (ø)`
internal/compress/gob.go	`100.00% <100.00%> (+72.09%)`	⬆️
internal/db/storage/blob/s3/writer/option.go	`100.00% <100.00%> (+85.71%)`	⬆️
... and 11 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 59df91e...d7d999b. Read the comment docs.

…error-assert-instantiate-problem Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

github-actions · 2020-09-08T05:22:54Z

pkg/meta/redis/service/redis.go

@@ -260,7 +278,12 @@ func (c *client) deleteMulti(ctx context.Context, pfx, pfxInv string, keys ...st
 	var errs error
 	for k, res := range ress {
 		if err = res.Err(); err != nil {
-			errs = errors.Wrap(errs, errors.ErrRedisDeleteOperationFailed(k, err).Error())
+			err = errors.ErrRedisDeleteOperationFailed(k, err)
+			if errs == nil {


[golangci] _{reported by reviewdog 🐶}
if statements should only be cuddled with assignments used in the if statement itself (wsl)

github-actions · 2020-09-08T05:22:54Z

internal/db/rdb/mysql/mysql.go

+				err = errors.ErrMySQLConnectionPingFailed
+			}
+			cerr := ctx.Err()
+			if cerr != nil{


[golangci] _{reported by reviewdog 🐶}
File is not gofmt-ed with -s (gofmt)

kpango · 2020-09-08T05:47:44Z

/rebase
/format
/approve
/changelog

vdaas-ci · 2020-09-08T05:48:04Z

[CHANGELOG] Please edit the following lines.

[patch] bugfix error assertion (#680)
🤖 Automatically update k8s manifests (#679)

vdaas-ci · 2020-09-08T05:48:19Z

[REBASE] Rebase triggered by kpango for branch: bugfix/internal-errors/DB-IsXXXX-function-error-assert-instantiate-problem

vdaas-ci · 2020-09-08T05:48:24Z

[REBASE] Failed to rebase.

kpango · 2020-09-08T05:49:35Z

/format

vdaas-ci · 2020-09-08T05:50:54Z

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

Signed-off-by: vdaas-ci <ci@vdaas.org>

[patch] bugfix error assertion

a26faa2

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

github-actions bot added area/internal size/S type/bug Something isn't working priority/medium labels Sep 8, 2020

Merge branch 'master' into bugfix/internal-errors/DB-IsXXXX-function-…

5491f0e

…error-assert-instantiate-problem Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

kpango force-pushed the bugfix/internal-errors/DB-IsXXXX-function-error-assert-instantiate-problem branch from a1e2c77 to 5491f0e Compare September 8, 2020 04:38

fix

d0644d5

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>

github-actions bot added area/meta size/M and removed size/S labels Sep 8, 2020

github-actions bot reviewed Sep 8, 2020

View reviewed changes

rinx previously approved these changes Sep 8, 2020

View reviewed changes

🤖 Update license headers / Format go codes and yaml files

d7d999b

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci dismissed rinx’s stale review via d7d999b September 8, 2020 05:51

kpango merged commit e3e2d63 into master Sep 8, 2020

kpango deleted the bugfix/internal-errors/DB-IsXXXX-function-error-assert-instantiate-problem branch September 8, 2020 05:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[patch] bugfix error assertion #680

[patch] bugfix error assertion #680

kpango commented Sep 8, 2020 •

edited by rinx

Loading

pull-assistant bot commented Sep 8, 2020 •

edited

Loading

vdaas-ci commented Sep 8, 2020

codecov bot commented Sep 8, 2020 •

edited

Loading

github-actions bot Sep 8, 2020

github-actions bot Sep 8, 2020

kpango commented Sep 8, 2020

vdaas-ci commented Sep 8, 2020

vdaas-ci commented Sep 8, 2020

vdaas-ci commented Sep 8, 2020

kpango commented Sep 8, 2020

vdaas-ci commented Sep 8, 2020

[patch] bugfix error assertion #680

[patch] bugfix error assertion #680

Conversation

kpango commented Sep 8, 2020 • edited by rinx Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

pull-assistant bot commented Sep 8, 2020 • edited Loading

vdaas-ci commented Sep 8, 2020

codecov bot commented Sep 8, 2020 • edited Loading

Codecov Report

github-actions bot Sep 8, 2020

Choose a reason for hiding this comment

github-actions bot Sep 8, 2020

Choose a reason for hiding this comment

kpango commented Sep 8, 2020

vdaas-ci commented Sep 8, 2020

vdaas-ci commented Sep 8, 2020

vdaas-ci commented Sep 8, 2020

kpango commented Sep 8, 2020

vdaas-ci commented Sep 8, 2020

kpango commented Sep 8, 2020 •

edited by rinx

Loading

pull-assistant bot commented Sep 8, 2020 •

edited

Loading

codecov bot commented Sep 8, 2020 •

edited

Loading