Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pass CFLAGS, CXXFLAGS to NGT build command #683

Merged
merged 2 commits into from
Sep 8, 2020
Merged

pass CFLAGS, CXXFLAGS to NGT build command #683

merged 2 commits into from
Sep 8, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Sep 8, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

passing CXXFLAGS to CGO_CXXFLAGS.
This is just for workaround for SIGILL on initialize phase of Agent-NGT

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.15.1
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Sep 8, 2020 •
edited
Loading

Score: 1.00

Best reviewed: commit by commit

Optimal code review plan

     # This is a combination of 4 commits.

     🔧 use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS

Powered by Pull Assistant. Last update 0bee00e ... 7c81459. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 8, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@rinx rinx changed the title pass CXXFLAGS to CGO_CXXFLAGS... pass CFLAGS, CXXFLAGS to NGT build command Sep 8, 2020
@rinx rinx force-pushed the bugfix/build-option/disable-avx512-by-cgo-cxxflags branch 2 times, most recently from 0c44c5f to df6bca4 Compare September 8, 2020 10:03
@rinx rinx marked this pull request as ready for review September 8, 2020 10:04
@rinx
Copy link
Contributor Author

rinx commented Sep 8, 2020

/rebase

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Sep 8, 2020

[REBASE] Rebase triggered by rinx for branch: bugfix/build-option/disable-avx512-by-cgo-cxxflags

@rinx rinx requested review from kmrmt and kpango September 8, 2020 10:05
@rinx @actions-user
# This is a combination of 4 commits.
0bee00e 
# This is the 1st commit message:

:wrench: pass CXXFLAGS to CGO_CXXFLAGS...

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

# This is the commit message #2:

:construction: wip

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

# This is the commit message #3:

:wrench: add CGO_CFLAGS, CGO_CPPFLAGS

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

# This is the commit message #4:

:wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx @actions-user
🔧 use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS
7c81459 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

:construction: wip

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

:wrench: add CGO_CFLAGS, CGO_CPPFLAGS

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

:wrench: use CMAKE_C_FLAGS, CMAKE_CXX_FLAGS

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

:fire: remove useless line

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@vdaas-ci vdaas-ci force-pushed the bugfix/build-option/disable-avx512-by-cgo-cxxflags branch from df6bca4 to 7c81459 Compare September 8, 2020 10:05
kpango
kpango approved these changes Sep 8, 2020
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 3fff839 into master Sep 8, 2020
@kpango kpango deleted the bugfix/build-option/disable-avx512-by-cgo-cxxflags branch September 8, 2020 10:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpango kpango kpango approved these changes

@kmrmt kmrmt Awaiting requested review from kmrmt

Assignees
No one assigned
Labels
area/makefile priority/medium size/S team/sre SRE team type/bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rinx @vdaas-ci @kpango