-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create s3/session test #702
Conversation
Best reviewed: commit by commit
|
[CHATOPS:HELP] ChatOps commands.
|
Codecov Report
@@ Coverage Diff @@
## master #702 +/- ##
==========================================
+ Coverage 14.31% 14.66% +0.34%
==========================================
Files 419 419
Lines 19420 19449 +29
==========================================
+ Hits 2780 2852 +72
+ Misses 16406 16372 -34
+ Partials 234 225 -9
Continue to review full report at Codecov.
|
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-test-s3-session |
00c1d0a
to
b17bd44
Compare
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-test-s3-session |
f6f2e1e
to
86ff508
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kevindiu leave comments
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase |
[REBASE] Rebase triggered by vankichi for branch: test/internal/add-test-s3-session |
c641a28
to
898f0cd
Compare
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-test-s3-session |
c0018c6
to
b41a3d5
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase |
[REBASE] Rebase triggered by vankichi for branch: test/internal/add-test-s3-session |
b41a3d5
to
7267e77
Compare
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
/rebase |
[REBASE] Rebase triggered by vankichi for branch: test/internal/add-test-s3-session |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by vankichi.
Description:
This PR implements internal s3/session.go test.
It includes the refactoring on FOP base on the coding guideline
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: