Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create s3/session test #702

Merged
merged 6 commits into from
Sep 29, 2020
Merged

Create s3/session test #702

merged 6 commits into from
Sep 29, 2020

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Sep 15, 2020

Description:

This PR implements internal s3/session.go test.
It includes the refactoring on FOP base on the coding guideline

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Sep 15, 2020

Score: 0.99

Best reviewed: commit by commit


Optimal code review plan

     add test

     add session test

     fix

     fix

     Remove unused code

     comment unused code

Powered by Pull Assistant. Last update 34d34ed ... a815d53. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

internal/test/comparator/standard.go Show resolved Hide resolved
internal/test/comparator/standard.go Show resolved Hide resolved
internal/test/comparator/standard.go Show resolved Hide resolved
internal/test/comparator/standard.go Show resolved Hide resolved
internal/test/comparator/standard.go Show resolved Hide resolved
internal/test/comparator/standard.go Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Sep 15, 2020

Codecov Report

Merging #702 into master will increase coverage by 0.34%.
The diff coverage is 42.85%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #702      +/-   ##
==========================================
+ Coverage   14.31%   14.66%   +0.34%     
==========================================
  Files         419      419              
  Lines       19420    19449      +29     
==========================================
+ Hits         2780     2852      +72     
+ Misses      16406    16372      -34     
+ Partials      234      225       -9     
Impacted Files Coverage Δ
pkg/gateway/vald/handler/grpc/handler.go 0.00% <0.00%> (ø)
internal/db/storage/blob/s3/session/option.go 52.38% <46.80%> (+52.38%) ⬆️
internal/db/storage/blob/s3/session/session.go 94.59% <100.00%> (+94.59%) ⬆️
internal/worker/queue.go 100.00% <0.00%> (+1.66%) ⬆️
internal/worker/worker.go 84.37% <0.00%> (+3.12%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a1dabb...a815d53. Read the comment docs.

@kevindiu kevindiu changed the title Create s3/session test [WIP] Create s3/session test Sep 16, 2020
@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-test-s3-session

@vdaas-ci vdaas-ci force-pushed the test/internal/add-test-s3-session branch from 00c1d0a to b17bd44 Compare September 17, 2020 07:30
@kevindiu kevindiu changed the title [WIP] Create s3/session test Create s3/session test Sep 23, 2020
@kevindiu kevindiu requested a review from hlts2 September 23, 2020 05:29
@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-test-s3-session

@vdaas-ci vdaas-ci force-pushed the test/internal/add-test-s3-session branch from f6f2e1e to 86ff508 Compare September 23, 2020 05:33
hlts2
hlts2 previously approved these changes Sep 23, 2020
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kevindiu leave comments

internal/db/storage/blob/s3/session/session_test.go Outdated Show resolved Hide resolved
vankichi
vankichi previously approved these changes Sep 24, 2020
Copy link
Contributor

@vankichi vankichi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hlts2
hlts2 previously approved these changes Sep 24, 2020
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/add-test-s3-session

@vdaas-ci vdaas-ci dismissed stale reviews from hlts2 and vankichi via 898f0cd September 24, 2020 05:21
@vdaas-ci vdaas-ci force-pushed the test/internal/add-test-s3-session branch from c641a28 to 898f0cd Compare September 24, 2020 05:21
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@kevindiu
Copy link
Contributor Author

/rebase

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-test-s3-session

@vdaas-ci vdaas-ci force-pushed the test/internal/add-test-s3-session branch from c0018c6 to b41a3d5 Compare September 24, 2020 07:39
hlts2
hlts2 previously approved these changes Sep 24, 2020
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

vankichi
vankichi previously approved these changes Sep 28, 2020
@vankichi
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/add-test-s3-session

@vdaas-ci vdaas-ci dismissed stale reviews from vankichi and hlts2 via 7267e77 September 28, 2020 09:48
@vdaas-ci vdaas-ci force-pushed the test/internal/add-test-s3-session branch from b41a3d5 to 7267e77 Compare September 28, 2020 09:48
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci
vdaas-ci previously approved these changes Sep 28, 2020
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi
Copy link
Contributor

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by vankichi for branch: test/internal/add-test-s3-session

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by vankichi.

@vankichi vankichi merged commit 3eb2dd9 into master Sep 29, 2020
@vankichi vankichi deleted the test/internal/add-test-s3-session branch September 29, 2020 04:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants