Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve CI builds: use DOCKER_BUILDKIT #706

Merged
merged 2 commits into from
Sep 17, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Sep 17, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

improve CI builds

  • use DOCKER_BUILDKIT
  • use docker-login action

use DOCKER_BUILDKIT

for Agent-NGT builds,
before: 5m 3s
スクリーンショット 2020-09-17 10 33 32
after: 3m 41s
スクリーンショット 2020-09-17 10 33 26

Related Issue:

nothing

How Has This Been Tested?:

nothing

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@pull-assistant
Copy link

pull-assistant bot commented Sep 17, 2020

Score: 1.00

Best reviewed: commit by commit


Optimal code review plan

     🐳 use DOCKER_BUILDKIT

     🔧 use docker-login action

Powered by Pull Assistant. Last update d23513e ... 6fbf41a. Read the comment docs.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the refactor/ci/use-docker-buildkit branch from 64fb3ed to d23513e Compare September 17, 2020 01:35
@rinx rinx marked this pull request as ready for review September 17, 2020 02:31
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit c295563 into master Sep 17, 2020
@kpango kpango deleted the refactor/ci/use-docker-buildkit branch September 17, 2020 03:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants