Cassandra option test (part 2)

[kevindiu]

Description:

This PR implements cassandra option test.
It also includes the refactoring of FOP written in guideline.

Related Issue:

How Has This Been Tested?:

Environment:

• Go Version: 1.15.2
• Docker Version: 19.03.8
• Kubernetes Version: 1.18.2
• NGT Version: 1.12.1

Types of changes:

• Bug fix [type/bug]
• New feature [type/feature]
• Add tests [type/test]
• Security related changes [type/security]
• Add documents [type/documentation]
• Refactoring [type/refactoring]
• Update dependencies [type/dependency]
• Update benchmarks and performances [type/bench]
• Update CI [type/ci]

Changes to Core Features:

• Have you added an explanation of what your changes do and why you'd like us to include them?
• Have you written new tests for your core changes, as applicable?
• Have you successfully ran tests with your changes locally?

Checklist:

• I have read the CONTRIBUTING document.
• I have checked open Pull Requests for the similar feature or fixes?
• I have added tests and benchmarks to cover my changes.
• I have ensured all new and existing tests passed.
• I have commented my code, particularly in hard-to-understand areas
• I have updated the documentation accordingly.

[pull-assistant]

Best reviewed: commit by commit

---

Optimal code review plan

     add test

     add test

     add test

     fix

Powered by Pull Assistant. Last update f258470 ... c1f3e62. Read the comment docs.

[kevindiu]

/rebase

[vdaas-ci]

[CHATOPS:HELP] ChatOps commands.

• 🙆‍♀️ /approve - approve
• 💌 /changelog - add changelog comment
• 🍱 /format - format codes and add licenses
• ✅ /gen-test - generate test codes
• 🏷️ /label - add labels
• ⏪ /rebase - rebase master

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/cassandra-option-part2

[codecov]

Codecov Report

Merging #724 into master will increase coverage by 0.46%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #724      +/-   ##
==========================================
+ Coverage   14.79%   15.25%   +0.46%     
==========================================
  Files         419      419              
  Lines       19449    19477      +28     
==========================================
+ Hits         2878     2972      +94     
+ Misses      16347    16286      -61     
+ Partials      224      219       -5     

Impacted Files	Coverage Δ
internal/db/nosql/cassandra/option.go	58.33% <100.00%> (+34.22%)	⬆️
internal/worker/worker.go	82.29% <0.00%> (+1.04%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0d5880f...b443696. Read the comment docs.

[kevindiu]

/rebase

[vdaas-ci]

[REBASE] Rebase triggered by kevindiu for branch: test/internal/cassandra-option-part2

[hlts2]

could you please add test about the following link?

vald/internal/db/nosql/cassandra/option.go

Line 210 in e4ad9b8

actual, ok := consistenciesMap[strings.TrimSpace(strings.Trim(strings.Trim(strings.ToLower(consistency), "_"), "-"))]

I think this code is comprex, so we should add other pattern.

[hlts2]

LGTM

[vankichi]

/rebase
/format
/approve

[vdaas-ci]

[REBASE] Rebase triggered by vankichi for branch: test/internal/cassandra-option-part2

[vdaas-ci]

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

[vdaas-ci]

[APPROVED] This PR is approved by vankichi.