CI: Make docker builds fast again #756

rinx · 2020-10-06T07:46:10Z

Description:

To make builds fast, this PR includes these changes.

remove build dependency between vald-base and vald-xxx images
- remove dependency in Makefile.d/docker.mk
- add golang stage in each image
- add GO_VERSION build arg in each image
remove caches for vald-base in workflows

Also, this PR includes README updates & CHANGELOG template updates

Related Issue:

merge this PR after #752 is merged

How Has This Been Tested?:

Nothing

Environment:

Go Version: 1.15.2
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :whale: :tag: revise golang image tag Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

vdaas-ci · 2020-10-06T07:46:27Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

LanguageTool

hack/CHANGELOG.template.md|63 col 60| Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|63 col 69| Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|69 col 51| Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|69 col 60| Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|70 col 64| Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|70 col 73| Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|76 col 50| Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|76 col 59| Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|77 col 63| Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|77 col 72| Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|83 col 50| Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|83 col 59| Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|84 col 63| Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY
hack/CHANGELOG.template.md|84 col 72| Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-06T09:54:30Z

hack/CHANGELOG.template.md

+  <tr>
+    <td>Agent NGT</td>
+    <td>
+      <code>docker pull vdaas/vald-agent-ngt:{{ version }}</code><br/>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-06T09:54:30Z

hack/CHANGELOG.template.md

+  <tr>
+    <td>Agent NGT</td>
+    <td>
+      <code>docker pull vdaas/vald-agent-ngt:{{ version }}</code><br/>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-06T09:54:31Z

hack/CHANGELOG.template.md

+    <td>Agent NGT</td>
+    <td>
+      <code>docker pull vdaas/vald-agent-ngt:{{ version }}</code><br/>
+      <code>docker pull ghcr.io/vdaas/vald/vald-agent-ngt:{{ version }}</code>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-06T09:54:31Z

hack/CHANGELOG.template.md

+    <td>Agent NGT</td>
+    <td>
+      <code>docker pull vdaas/vald-agent-ngt:{{ version }}</code><br/>
+      <code>docker pull ghcr.io/vdaas/vald/vald-agent-ngt:{{ version }}</code>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-06T09:54:31Z

hack/CHANGELOG.template.md

+  <tr>
+    <td>Agent sidecar</td>
+    <td>
+      <code>docker pull vdaas/vald-agent-sidecar:{{ version }}</code><br/>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-06T09:54:33Z

hack/CHANGELOG.template.md

+  <tr>
+    <td>Compressor</td>
+    <td>
+      <code>docker pull vdaas/vald-manager-compressor:{{ version }}</code><br/>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-06T09:54:34Z

hack/CHANGELOG.template.md

+    <td>Compressor</td>
+    <td>
+      <code>docker pull vdaas/vald-manager-compressor:{{ version }}</code><br/>
+      <code>docker pull ghcr.io/vdaas/vald/vald-manager-compressor:{{ version }}</code>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-06T09:54:34Z

hack/CHANGELOG.template.md

+    <td>Compressor</td>
+    <td>
+      <code>docker pull vdaas/vald-manager-compressor:{{ version }}</code><br/>
+      <code>docker pull ghcr.io/vdaas/vald/vald-manager-compressor:{{ version }}</code>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-06T09:54:34Z

hack/CHANGELOG.template.md

+  <tr>
+    <td>Meta Redis</td>
+    <td>
+      <code>docker pull vdaas/vald-meta-redis:{{ version }}</code><br/>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-06T09:54:34Z

hack/CHANGELOG.template.md

+  <tr>
+    <td>Meta Redis</td>
+    <td>
+      <code>docker pull vdaas/vald-meta-redis:{{ version }}</code><br/>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

github-actions · 2020-10-07T02:01:14Z

hack/CHANGELOG.template.md

+    <td>Meta Redis</td>
+    <td>
+      <code>docker pull vdaas/vald-meta-redis:{{ version }}</code><br/>
+      <code>docker pull ghcr.io/vdaas/vald/vald-meta-redis:{{ version }}</code>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-07T02:01:14Z

hack/CHANGELOG.template.md

+    <td>Meta Redis</td>
+    <td>
+      <code>docker pull vdaas/vald-meta-redis:{{ version }}</code><br/>
+      <code>docker pull ghcr.io/vdaas/vald/vald-meta-redis:{{ version }}</code>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-07T02:01:14Z

hack/CHANGELOG.template.md

+  <tr>
+    <td>Meta Cassandra</td>
+    <td>
+      <code>docker pull vdaas/vald-meta-cassandra:{{ version }}</code><br/>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-07T02:01:14Z

hack/CHANGELOG.template.md

+  <tr>
+    <td>Meta Cassandra</td>
+    <td>
+      <code>docker pull vdaas/vald-meta-cassandra:{{ version }}</code><br/>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-07T02:01:14Z

hack/CHANGELOG.template.md

+    <td>Meta Cassandra</td>
+    <td>
+      <code>docker pull vdaas/vald-meta-cassandra:{{ version }}</code><br/>
+      <code>docker pull ghcr.io/vdaas/vald/vald-meta-cassandra:{{ version }}</code>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-07T02:01:15Z

hack/CHANGELOG.template.md

+    <td>Index Manager</td>
+    <td>
+      <code>docker pull vdaas/vald-manager-index:{{ version }}</code><br/>
+      <code>docker pull ghcr.io/vdaas/vald/vald-manager-index:{{ version }}</code>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-07T02:01:15Z

hack/CHANGELOG.template.md

+  <tr>
+    <td>Helm Operator</td>
+    <td>
+      <code>docker pull vdaas/vald-helm-operator:{{ version }}</code><br/>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-07T02:01:15Z

hack/CHANGELOG.template.md

+  <tr>
+    <td>Helm Operator</td>
+    <td>
+      <code>docker pull vdaas/vald-helm-operator:{{ version }}</code><br/>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-07T02:01:15Z

hack/CHANGELOG.template.md

+    <td>Helm Operator</td>
+    <td>
+      <code>docker pull vdaas/vald-helm-operator:{{ version }}</code><br/>
+      <code>docker pull ghcr.io/vdaas/vald/vald-helm-operator:{{ version }}</code>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

github-actions · 2020-10-07T02:01:15Z

hack/CHANGELOG.template.md

+    <td>Helm Operator</td>
+    <td>
+      <code>docker pull vdaas/vald-helm-operator:{{ version }}</code><br/>
+      <code>docker pull ghcr.io/vdaas/vald/vald-helm-operator:{{ version }}</code>


[LanguageTool] _{reported by reviewdog 🐶}
Don't put a space before the closing parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: }
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

kpango · 2020-10-13T06:14:23Z

dockers/agent/core/ngt/Dockerfile

 ARG BASE_TAG=latest
 ARG DISTROLESS_IMAGE=gcr.io/distroless/static
 ARG DISTROLESS_IMAGE_TAG=nonroot
 ARG UPX_OPTIONS=-9

+FROM golang:${GO_VERSION} AS golang
+
 FROM vdaas/vald-base:${BASE_TAG} AS builder


do we need copy GOROOT from golang image?
I think vald-base already have GOROOT/{bin,src,misc,pkg}

Exactly we need it.

Considering a PR that updates versions/GO_VERSION file, it triggers builds of Docker images.
because GitHub Actions doesn't support dependencies between workflows, we must build vdaas/vald-base and others independently. Then, if agent/core/ngt/Dockerfile does'nt have copying stage of GOROOT, vdaas/vald-agent-ngt built using the former version of Go binaries.

I see, thank you for describe it.
LGTM
/format
/rebase
/approve

kpango · 2020-10-13T06:32:23Z

/format
/rebase
/approve

vdaas-ci · 2020-10-13T06:33:00Z

[REBASE] Rebase triggered by kpango for branch: ci/docker/make-builds-faster-again

vdaas-ci · 2020-10-13T06:33:05Z

[REBASE] Failed to rebase.

kpango · 2020-10-13T06:49:53Z

/format
/approve

vdaas-ci · 2020-10-13T06:55:52Z

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci

[APPROVED] This PR is approved by kpango.

rinx added 3 commits October 6, 2020 16:39

♻️ refactor dockerfile and makefile.d/docker.mk

a981a74

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com> :whale: :tag: revise golang image tag Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

💚 revise GitHub Actions yaml

e80a7ff

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

🎨 add .github/**/*.yml to format objects

8755a09

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

github-actions bot added area/makefile team/sre SRE team type/ci size/L priority/low labels Oct 6, 2020

rinx added 2 commits October 6, 2020 18:09

📝 update README table

b1dd57c

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

📝 update README: use badge for DockerHub

e4d2177

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

rinx force-pushed the ci/docker/make-builds-faster-again branch from 021f660 to e4d2177 Compare October 6, 2020 09:28

rinx added 2 commits October 6, 2020 18:36

📝 update README: use badge for ghcr.io

a98b61c

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

📝 update CHANGELOG template

ab3806d

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

github-actions bot reviewed Oct 6, 2020

View reviewed changes

📝 simplify README table

63a228d

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

github-actions bot reviewed Oct 7, 2020

View reviewed changes

rinx requested a review from kpango October 7, 2020 05:13

rinx marked this pull request as ready for review October 8, 2020 00:18

rinx added 2 commits October 13, 2020 11:29

Merge branch 'master' into ci/docker/make-builds-faster-again

d0cffd8

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>

Merge branch 'master' into ci/docker/make-builds-faster-again

11be8d4

kpango reviewed Oct 13, 2020

View reviewed changes

Merge branch 'master' into ci/docker/make-builds-faster-again

f9bc4d8

🤖 Update license headers / Format go codes and yaml files

e74f37b

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci approved these changes Oct 13, 2020

View reviewed changes

kpango merged commit c81622e into master Oct 13, 2020

kpango deleted the ci/docker/make-builds-faster-again branch October 13, 2020 06:57

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CI: Make docker builds fast again #756

CI: Make docker builds fast again #756

rinx commented Oct 6, 2020 •

edited

Loading

vdaas-ci commented Oct 6, 2020

github-actions bot left a comment

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 6, 2020

github-actions bot Oct 7, 2020

github-actions bot Oct 7, 2020

github-actions bot Oct 7, 2020

github-actions bot Oct 7, 2020

github-actions bot Oct 7, 2020

github-actions bot Oct 7, 2020

github-actions bot Oct 7, 2020

github-actions bot Oct 7, 2020

github-actions bot Oct 7, 2020

github-actions bot Oct 7, 2020

kpango Oct 13, 2020

rinx Oct 13, 2020

kpango Oct 13, 2020

kpango commented Oct 13, 2020

vdaas-ci commented Oct 13, 2020

vdaas-ci commented Oct 13, 2020

kpango commented Oct 13, 2020

vdaas-ci commented Oct 13, 2020

vdaas-ci left a comment

CI: Make docker builds fast again #756

CI: Make docker builds fast again #756

Conversation

rinx commented Oct 6, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Oct 6, 2020

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 6, 2020

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

github-actions bot Oct 7, 2020

Choose a reason for hiding this comment

kpango Oct 13, 2020

Choose a reason for hiding this comment

rinx Oct 13, 2020

Choose a reason for hiding this comment

kpango Oct 13, 2020

Choose a reason for hiding this comment

kpango commented Oct 13, 2020

vdaas-ci commented Oct 13, 2020

vdaas-ci commented Oct 13, 2020

kpango commented Oct 13, 2020

vdaas-ci commented Oct 13, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

rinx commented Oct 6, 2020 •

edited

Loading