Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

upgrade KinD, Helm, valdcli, telepresence, tensorlfow, operator-sdk, … #776

Merged
merged 1 commit into from
Oct 14, 2020
Merged

upgrade KinD, Helm, valdcli, telepresence, tensorlfow, operator-sdk, … #776

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions Makefile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,11 +50,11 @@ TENSORFLOW_C_VERSION := $(eval TENSORFLOW_C_VERSION := $(shell cat versions/TENS

OPERATOR_SDK_VERSION := $(eval OPERATOR_SDK_VERSION := $(shell cat versions/OPERATOR_SDK_VERSION))$(OPERATOR_SDK_VERSION)

KIND_VERSION ?= v0.8.1
HELM_VERSION ?= v3.2.4
HELM_DOCS_VERSION ?= 0.13.0
VALDCLI_VERSION ?= v0.0.50
TELEPRESENCE_VERSION ?= 0.105
KIND_VERSION ?= v0.9.0
HELM_VERSION ?= v3.3.4
HELM_DOCS_VERSION ?= 1.3.0
VALDCLI_VERSION ?= v0.0.61
TELEPRESENCE_VERSION ?= 0.108

SWAP_DEPLOYMENT_TYPE ?= deployment
SWAP_IMAGE ?= ""
Expand Down
2 changes: 1 addition & 1 deletion charts/vald-helm-operator/README.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ vald-helm-operator

This is a Helm chart to install vald-helm-operator.

{{ template "chart.versionLine" . }}
Current chart version is `{{ template "chart.version" . }}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Don't put a space before the full stop (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: .
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION


Table of Contents
---
Expand Down
2 changes: 0 additions & 2 deletions charts/vald/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@ Run the following command to install the chart,

$ helm install vald-cluster vald/vald


Configuration
---

Expand Down Expand Up @@ -935,7 +934,6 @@ Configuration
| meta.volumeMounts | list | `[]` | volume mounts |
| meta.volumes | list | `[]` | volumes |


Miscellaneous
---

Expand Down
2 changes: 1 addition & 1 deletion charts/vald/README.md.gotmpl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ Vald

This is a Helm chart to install Vald components.

{{ template "chart.versionLine" . }}
Current chart version is `{{ template "chart.version" . }}`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Don't put a space after the opening parenthesis (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: {
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Don't put a space before the full stop (COMMA_PARENTHESIS_WHITESPACE)
Suggestions: .
Rule: https://community.languagetool.org/rule/show/COMMA_PARENTHESIS_WHITESPACE?lang=en-US
Category: TYPOGRAPHY

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[LanguageTool] reported by reviewdog 🐶
Loose punctuation mark. (UNLIKELY_OPENING_PUNCTUATION[1])
Suggestions: ``
Rule: https://community.languagetool.org/rule/show/UNLIKELY_OPENING_PUNCTUATION?lang=en-US&subId=1
Category: PUNCTUATION


Table of Contents
---
Expand Down
2 changes: 1 addition & 1 deletion versions/OPERATOR_SDK_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
v1.0.0
v1.0.1
2 changes: 1 addition & 1 deletion versions/TENSORFLOW_C_VERSION
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.15.0
2.3.0
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we have a problem with tf v2.0.0~2.2.0, can we use v2.3.0 ? If we can use,it should be v2.3.1

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kpango there's no problem. @datelier confirmed that v2.3.0 is okay.

there's no prebuilt lib of version v2.3.1 here, so it should be v2.3.0.
https://www.tensorflow.org/install/lang_c

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

okay, I understand LGTM

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks