Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[patch] add 3 new distance type support for agent-ngt #780

Merged
merged 7 commits into from
Oct 19, 2020

Conversation

kpango
Copy link
Collaborator

@kpango kpango commented Oct 17, 2020

Signed-off-by: kpango i.can.feel.gravity@gmail.com

Description:

add 3 new distance type support

  • NormalizedAngle
  • NormalizedCosine
  • Jaccard

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

@codecov
Copy link

codecov bot commented Oct 17, 2020

Codecov Report

Merging #780 into master will decrease coverage by 0.17%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #780      +/-   ##
==========================================
- Coverage   16.92%   16.74%   -0.18%     
==========================================
  Files         421      420       -1     
  Lines       19528    19480      -48     
==========================================
- Hits         3305     3262      -43     
+ Misses      15999    15995       -4     
+ Partials      224      223       -1     
Impacted Files Coverage Δ
internal/db/storage/blob/s3/s3.go 0.00% <0.00%> (ø)
pkg/gateway/vald/handler/grpc/handler.go 0.00% <0.00%> (ø)
internal/db/storage/blob/s3/reader/reader.go 97.72% <33.33%> (-2.28%) ⬇️
internal/db/storage/blob/s3/reader/option.go 100.00% <100.00%> (ø)
internal/net/net.go
internal/worker/worker.go 83.33% <0.00%> (+1.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b9325b...e0a0fbb. Read the comment docs.

fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@rinx
Copy link
Contributor

rinx commented Oct 19, 2020

vald/charts/vald/values.yaml

Lines 1250 to 1254 in d262d39

# @schema {"name": "agent.ngt.distance_type", "type": "string", "enum": ["l1", "l2", "angle", "hamming", "cos", "cosine", "normalizedangle", "normalizedcosine"]}
# agent.ngt.distance_type -- distance type.
# it should be `l1`, `l2`, `angle`, `hamming`, `cosine`, `normalizedangle` or `normalizedcosine`.
# for further details: https://github.com/yahoojapan/NGT/wiki/Command-Quick-Reference
distance_type: l2

please update here.

fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango
Copy link
Collaborator Author

kpango commented Oct 19, 2020

@rinx fixed

fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
@kpango
Copy link
Collaborator Author

kpango commented Oct 19, 2020

@rinx sorry I also updated docs agent-on-docker.md

docs/tutorial/agent-on-docker.md Outdated Show resolved Hide resolved
internal/core/ngt/option.go Outdated Show resolved Hide resolved
Yusuke Kato and others added 3 commits October 19, 2020 11:02
Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>
fix
Signed-off-by: kpango <i.can.feel.gravity@gmail.com>
Copy link
Contributor

@rinx rinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems okay.

@kpango kpango merged commit e0d562b into master Oct 19, 2020
@kpango kpango deleted the feature/agent/add-distance-type branch October 19, 2020 02:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants