Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add internal/db/cassandra/conviction test #799

Merged
merged 3 commits into from
Oct 27, 2020

Conversation

kevindiu
Copy link
Contributor

@kevindiu kevindiu commented Oct 27, 2020

Description:

This PR creates internal/db/nocql/cassandra/conviction.go tests

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

internal/db/nosql/cassandra/conviction_test.go Outdated Show resolved Hide resolved
internal/db/nosql/cassandra/conviction_test.go Outdated Show resolved Hide resolved
internal/db/nosql/cassandra/conviction_test.go Outdated Show resolved Hide resolved
Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>
@kevindiu kevindiu requested a review from hlts2 October 27, 2020 02:35
@codecov
Copy link

codecov bot commented Oct 27, 2020

Codecov Report

Merging #799 into master will decrease coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #799      +/-   ##
==========================================
- Coverage   17.53%   17.23%   -0.31%     
==========================================
  Files         421      420       -1     
  Lines       19554    19500      -54     
==========================================
- Hits         3429     3361      -68     
- Misses      15915    15927      +12     
- Partials      210      212       +2     
Impacted Files Coverage Δ
internal/db/nosql/cassandra/conviction.go 100.00% <100.00%> (+100.00%) ⬆️
internal/db/storage/blob/s3/reader/reader.go 65.90% <0.00%> (-31.82%) ⬇️
internal/errgroup/group.go 92.42% <0.00%> (-1.52%) ⬇️
internal/net/net.go
internal/worker/worker.go 83.33% <0.00%> (+1.04%) ⬆️
internal/worker/queue.go 98.33% <0.00%> (+3.33%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4cdb726...8ad1d01. Read the comment docs.

Copy link
Contributor

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango kpango merged commit 5e2c8bb into master Oct 27, 2020
@kpango kpango deleted the test/internal/nosql/cassandra/coviction-test branch October 27, 2020 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants