-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CI: Add reviewdog-k8s #824
Conversation
[CHATOPS:HELP] ChatOps commands.
|
k8s/agent/statefulset.yaml
Outdated
@@ -29,7 +29,7 @@ metadata: | |||
spec: | |||
serviceName: vald-agent-ngt | |||
podManagementPolicy: Parallel | |||
replicas: 5 | |||
replicas: "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
reported by reviewdog 🐶
Invalid type. Expected: [integer,null], given: string
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
a095763
to
390b88e
Compare
LGTM But, I think it's better to integrate kubeval with https://github.com/stackrox/kube-linter |
aha, i'll revise this PR to integrate with it. thanks. |
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
a1a0b5b
to
4405748
Compare
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
https://github.com/vdaas/vald/runs/1378253698?check_suite_focus=true |
@kpango ready again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Related Issue:
nothing
How Has This Been Tested?:
nothing
Environment:
Types of changes:
Changes to Core Features:
Checklist: