Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add FOSSA scan workflow & .fossa.yml #846

Merged
merged 2 commits into from
Nov 19, 2020
Merged

Add FOSSA scan workflow & .fossa.yml #846

merged 2 commits into from
Nov 19, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Nov 17, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

Add FOSSA scan workflow that is triggered by labeled event (actions/fossa) of PRs.
also, .fossa.yml is added to run FOSSA correctly.

Related Issue:

Nothing

How Has This Been Tested?:

Nothing

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • ✅ /gen-test - generate test codes
  • 🏷️ /label - add labels
  • ⏪ /rebase - rebase master

@rinx
Copy link
Contributor Author

rinx commented Nov 17, 2020

/label actions/fossa

@rinx rinx force-pushed the ci/fossa-cli/run-fossa-using-chatops branch from 8723cf9 to 998c99c Compare November 17, 2020 08:23
@rinx rinx force-pushed the ci/fossa-cli/run-fossa-using-chatops branch from 998c99c to 98a5f4b Compare November 17, 2020 09:13
@rinx rinx force-pushed the ci/fossa-cli/run-fossa-using-chatops branch from 98a5f4b to c053c0a Compare November 17, 2020 09:23
@rinx rinx force-pushed the ci/fossa-cli/run-fossa-using-chatops branch from c053c0a to 67707e5 Compare November 17, 2020 09:27
@rinx rinx force-pushed the ci/fossa-cli/run-fossa-using-chatops branch from 67707e5 to 2e128bd Compare November 17, 2020 09:33
@rinx rinx force-pushed the ci/fossa-cli/run-fossa-using-chatops branch from 2e128bd to e7f6799 Compare November 17, 2020 09:37
@rinx rinx force-pushed the ci/fossa-cli/run-fossa-using-chatops branch from e7f6799 to bdf6851 Compare November 17, 2020 09:43
@rinx rinx force-pushed the ci/fossa-cli/run-fossa-using-chatops branch from c46d137 to 8aff23d Compare November 18, 2020 03:22
@vdaas vdaas deleted a comment from github-actions bot Nov 18, 2020
@vdaas vdaas deleted a comment from github-actions bot Nov 18, 2020
@rinx rinx force-pushed the ci/fossa-cli/run-fossa-using-chatops branch from 8aff23d to 1aea23a Compare November 18, 2020 06:44
@github-actions
Copy link
Contributor

[FOSSA] The scan result will be available at https://app.fossa.com/projects/custom%2B21465%2Fvald/refs/branch/ci%2Ffossa-cli%2Frun-fossa-using-chatops/7f7026fa29e6a73d8d57ddbfb3cbe646edf2425c

@rinx rinx marked this pull request as ready for review November 18, 2020 06:54
@rinx
Copy link
Contributor Author

rinx commented Nov 18, 2020

📝 Once this PR is merged into master, we can remove FOSSA integration in this repository.

@rinx rinx requested a review from kpango November 18, 2020 06:56
kpango
kpango previously approved these changes Nov 18, 2020
View reviewed changes
Copy link
Collaborator

@kpango kpango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kpango
Copy link
Collaborator

kpango commented Nov 18, 2020

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kpango for branch: ci/fossa-cli/run-fossa-using-chatops

@rinx @kpango
👷 Add FOSSA scan workflow & .fossa.yml
e039465 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@github-actions github-actions bot force-pushed the ci/fossa-cli/run-fossa-using-chatops branch from 1aea23a to e039465 Compare November 18, 2020 09:10
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

@vdaas-ci
Copy link
Collaborator

[FORMAT] Failed to format.

@kpango
Copy link
Collaborator

kpango commented Nov 19, 2020

/format
/approve

@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kpango.

@vdaas-ci
Copy link
Collaborator

[FORMAT] Failed to format.

@rinx
Copy link
Contributor Author

rinx commented Nov 19, 2020

maybe GITHUB_TOKEN doesn't have a permission to modify the files under .github/workflows directory. so i'll run format manually in my local machine and push them.

@rinx
🎨 Format yamls
2dfd525 
Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@kpango
Copy link
Collaborator

kpango commented Nov 19, 2020

/approve

vdaas-ci
vdaas-ci approved these changes Nov 19, 2020
View reviewed changes
Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kpango.

@kpango kpango merged commit 428740c into master Nov 19, 2020
@kpango kpango deleted the ci/fossa-cli/run-fossa-using-chatops branch November 19, 2020 02:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vdaas-ci vdaas-ci vdaas-ci approved these changes

@kpango kpango kpango left review comments

Assignees
No one assigned
Labels
actions/fossa priority/low size/S team/sre SRE team type/ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rinx @vdaas-ci @kpango