Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build Helm schemas when building helm-operator image #879

Merged
merged 1 commit into from
Dec 14, 2020

Conversation

rinx
Copy link
Contributor

@rinx rinx commented Dec 9, 2020

Signed-off-by: Rintaro Okamura rintaro.okamura@gmail.com

Description:

During deploy tests of #519, it is founded that helm-operator image is not built with helm schemas.
In this PR, I modified Dockerfile of helm-operator image to build schemas.

Related Issue:

nothing

How Has This Been Tested?:

nothing.

Environment:

  • Go Version: 1.15.2
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.12.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Dec 9, 2020

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master

Signed-off-by: Rintaro Okamura <rintaro.okamura@gmail.com>
@rinx rinx force-pushed the refactor/dockers/helm-operator-build-with-schemas branch from eaf9eb0 to 859426d Compare December 9, 2020 06:48
@rinx
Copy link
Contributor Author

rinx commented Dec 14, 2020

This PR includes changes only for Helm Operator's Dockerfile, I'll merge it.

@rinx rinx merged commit 9aeab03 into master Dec 14, 2020
@rinx rinx deleted the refactor/dockers/helm-operator-build-with-schemas branch December 14, 2020 08:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants