Implement internal/errors/blob test #888

kevindiu · 2020-12-16T05:36:11Z

Description:

This PR implements internal/errors/blob test

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.2
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.12.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

kevindiu · 2020-12-16T05:36:27Z

/rebase

vdaas-ci · 2020-12-16T05:41:56Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master

vdaas-ci · 2020-12-16T05:42:15Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/errors-blob-test

codecov · 2020-12-16T05:47:56Z

Codecov Report

Merging #888 (4e0d2a3) into master (2696dd3) will increase coverage by 0.03%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master     #888      +/-   ##
==========================================
+ Coverage   19.10%   19.14%   +0.03%     
==========================================
  Files         423      423              
  Lines       19600    19600              
==========================================
+ Hits         3745     3752       +7     
+ Misses      15638    15630       -8     
- Partials      217      218       +1

Impacted Files	Coverage Δ
internal/errors/blob.go	`57.14% <ø> (+57.14%)`	⬆️
internal/worker/queue.go	`95.00% <0.00%> (-5.00%)`	⬇️
internal/worker/worker.go	`83.33% <0.00%> (+1.04%)`	⬆️
internal/errgroup/group.go	`93.93% <0.00%> (+1.51%)`	⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2696dd3...e9b2636. Read the comment docs.

internal/errors/blob_test.go

internal/errors/blob.go

internal/errors/blob_test.go

kevindiu · 2020-12-21T03:07:28Z

/rebase

vdaas-ci · 2020-12-21T03:08:05Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/errors-blob-test

hlts2

LGTM

internal/errors/blob_test.go

kevindiu · 2020-12-22T04:29:33Z

/rebase

vdaas-ci · 2020-12-22T04:30:08Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/errors-blob-test

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

hlts2

LGTM

vankichi

LGTM

vankichi · 2020-12-22T04:56:47Z

/rebase
/format
/approve

vdaas-ci · 2020-12-22T04:57:23Z

[REBASE] Rebase triggered by vankichi for branch: test/internal/errors-blob-test

vdaas-ci · 2020-12-22T04:58:09Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

vdaas-ci

[APPROVED] This PR is approved by vankichi.

kevindiu changed the title ~~Test/internal/errors/blob test~~ Implement internal/errors/blob test Dec 16, 2020

github-actions bot added area/internal team/set SET team size/L type/test Adding tests priority/low labels Dec 16, 2020

github-actions bot force-pushed the test/internal/errors-blob-test branch from 47d27c1 to bad32d5 Compare December 16, 2020 05:42

kevindiu requested a review from hlts2 December 17, 2020 01:28

hlts2 requested changes Dec 17, 2020

View reviewed changes

vankichi reviewed Dec 18, 2020

View reviewed changes

internal/errors/blob_test.go Outdated Show resolved Hide resolved

internal/errors/blob_test.go Outdated Show resolved Hide resolved

internal/errors/blob_test.go Outdated Show resolved Hide resolved

internal/errors/blob_test.go Outdated Show resolved Hide resolved

kevindiu requested review from hlts2 and vankichi December 21, 2020 03:07

github-actions bot force-pushed the test/internal/errors-blob-test branch from e300301 to a3f07fa Compare December 21, 2020 03:08

hlts2 previously approved these changes Dec 21, 2020

View reviewed changes

vankichi reviewed Dec 22, 2020

View reviewed changes

internal/errors/blob_test.go Outdated Show resolved Hide resolved

internal/errors/blob_test.go Outdated Show resolved Hide resolved

internal/errors/blob_test.go Outdated Show resolved Hide resolved

kevindiu commented Dec 22, 2020

View reviewed changes

internal/errors/blob_test.go Outdated Show resolved Hide resolved

kevindiu dismissed hlts2’s stale review via 3bd88c5 December 22, 2020 02:29

kevindiu requested review from hlts2 and vankichi December 22, 2020 04:29

kevindiu added 3 commits December 22, 2020 04:30

initial commit

e63f9a3

implement blob test

603c195

fix invalid package

e355145

kevindiu and others added 5 commits December 22, 2020 04:30

Apply suggestions from code review

42f2c75

Co-authored-by: Hiroto Funakoshi <hiroto.funakoshi.hiroto@gmail.com>

add nil value test cases

68fd5fe

Apply suggestions from code review

9732a23

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

fix compilation error

7dcbb22

Apply suggestions from code review

e9b2636

Co-authored-by: Kiichiro YUKAWA <kyukawa315@gmail.com>

github-actions bot force-pushed the test/internal/errors-blob-test branch from 3bd88c5 to e9b2636 Compare December 22, 2020 04:30

hlts2 approved these changes Dec 22, 2020

View reviewed changes

vankichi approved these changes Dec 22, 2020

View reviewed changes

vdaas-ci approved these changes Dec 22, 2020

View reviewed changes

vankichi merged commit 923ef5a into master Dec 22, 2020

vankichi deleted the test/internal/errors-blob-test branch December 22, 2020 06:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement internal/errors/blob test #888

Implement internal/errors/blob test #888

kevindiu commented Dec 16, 2020 •

edited

Loading

kevindiu commented Dec 16, 2020

vdaas-ci commented Dec 16, 2020

vdaas-ci commented Dec 16, 2020

codecov bot commented Dec 16, 2020 •

edited

Loading

kevindiu commented Dec 21, 2020

vdaas-ci commented Dec 21, 2020

hlts2 left a comment

kevindiu commented Dec 22, 2020

vdaas-ci commented Dec 22, 2020

hlts2 left a comment

vankichi left a comment

vankichi commented Dec 22, 2020

vdaas-ci commented Dec 22, 2020

vdaas-ci commented Dec 22, 2020

vdaas-ci left a comment

Implement internal/errors/blob test #888

Implement internal/errors/blob test #888

Conversation

kevindiu commented Dec 16, 2020 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

kevindiu commented Dec 16, 2020

vdaas-ci commented Dec 16, 2020

vdaas-ci commented Dec 16, 2020

codecov bot commented Dec 16, 2020 • edited Loading

Codecov Report

kevindiu commented Dec 21, 2020

vdaas-ci commented Dec 21, 2020

hlts2 left a comment

Choose a reason for hiding this comment

kevindiu commented Dec 22, 2020

vdaas-ci commented Dec 22, 2020

hlts2 left a comment

Choose a reason for hiding this comment

vankichi left a comment

Choose a reason for hiding this comment

vankichi commented Dec 22, 2020

vdaas-ci commented Dec 22, 2020

vdaas-ci commented Dec 22, 2020

vdaas-ci left a comment

Choose a reason for hiding this comment

kevindiu commented Dec 16, 2020 •

edited

Loading

codecov bot commented Dec 16, 2020 •

edited

Loading