create new test and refactor for errors/option #950

vankichi · 2021-01-25T05:19:16Z

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I created the new test for internal/errors/option.go.
Also, this PR includes below changes.

add comment each function or something external property.
refactor each Error() method due to panic.

grammar check is completed.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.7
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.13.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

vdaas-ci · 2021-01-25T05:19:35Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

internal/errors/option_test.go

internal/errors/option.go

codecov · 2021-01-25T05:35:20Z

Codecov Report

Merging #950 (566a9ea) into master (7e1997a) will increase coverage by 0.13%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #950      +/-   ##
==========================================
+ Coverage   15.19%   15.32%   +0.13%     
==========================================
  Files         492      492              
  Lines       25622    25626       +4     
==========================================
+ Hits         3893     3927      +34     
+ Misses      21487    21457      -30     
  Partials      242      242

Impacted Files	Coverage Δ
internal/errors/option.go	`100.00% <100.00%> (+100.00%)`	⬆️
internal/worker/worker.go	`83.33% <0.00%> (ø)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update faeea6a...566a9ea. Read the comment docs.

internal/errors/option_test.go

hlts2

I am sorry... I forgot to comment. 🙇
But I think the others is good 👍
Thank you always 🙇

internal/errors/option_test.go

hlts2

Thank you 🙇
LGTM

vankichi · 2021-02-01T00:49:40Z

/format

vdaas-ci · 2021-02-01T00:50:58Z

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

kevindiu

LGTM

kevindiu · 2021-02-01T09:40:48Z

/format
/rebase
/approve

vdaas-ci · 2021-02-01T09:42:15Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-option

vdaas-ci · 2021-02-01T09:43:27Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

vdaas-ci · 2021-02-01T09:53:50Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

vdaas-ci · 2021-02-01T09:56:04Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-option

kevindiu · 2021-02-01T09:59:22Z

/format
/approve

vdaas-ci · 2021-02-01T10:01:21Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

kevindiu · 2021-02-01T22:44:59Z

/rebase
/format
/approve

vdaas-ci · 2021-02-01T22:45:47Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-option

Signed-off-by: vankichi <kyukawa315@gmail.com>

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci · 2021-02-01T22:46:58Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

kevindiu · 2021-02-02T02:03:57Z

/rebase
/format
/approve

vdaas-ci · 2021-02-02T02:04:35Z

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-option

vdaas-ci · 2021-02-02T02:05:25Z

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

github-actions bot added area/internal team/set SET team labels Jan 25, 2021

github-actions bot added size/XXL type/test Adding tests priority/low labels Jan 25, 2021

github-actions bot reviewed Jan 25, 2021

View reviewed changes

vankichi changed the title ~~[WIP] create new test and refactor for errors/option~~ create new test and refactor for errors/option Jan 25, 2021

vankichi marked this pull request as ready for review January 25, 2021 05:31

vankichi requested review from hlts2 and kevindiu January 25, 2021 05:44

hlts2 reviewed Jan 26, 2021

View reviewed changes

internal/errors/option_test.go Outdated Show resolved Hide resolved

internal/errors/option_test.go Outdated Show resolved Hide resolved

internal/errors/option_test.go Outdated Show resolved Hide resolved

hlts2 reviewed Jan 27, 2021

View reviewed changes

github-actions bot added size/XL and removed size/XL labels Jan 27, 2021

hlts2 previously approved these changes Jan 27, 2021

View reviewed changes

kevindiu previously approved these changes Feb 1, 2021

View reviewed changes

vdaas-ci dismissed stale reviews from kevindiu and hlts2 via 4244bf6 February 1, 2021 09:42

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-option branch from 00df149 to 4244bf6 Compare February 1, 2021 09:42

github-actions bot added size/XL and removed size/XL labels Feb 1, 2021

github-actions bot added team/sre SRE team type/ci labels Feb 1, 2021

github-actions bot removed the size/XL label Feb 1, 2021

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-option branch from 577cccc to 82cf963 Compare February 1, 2021 09:56

github-actions bot added size/XL and removed size/XL labels Feb 1, 2021

vankichi and others added 7 commits February 1, 2021 22:45

✅ ♻️ create new test and refactor for errros/option

f441929

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix grammar and unncess codes

e4ab15b

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix missspel

746bfa2

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix testing groutine

6e7c12b

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix by review

dcdf2ab

Signed-off-by: vankichi <kyukawa315@gmail.com>

✅ fix by review

3ff0ebc

Signed-off-by: vankichi <kyukawa315@gmail.com>

🤖 Update license headers / Format go codes and yaml files

566a9ea

Signed-off-by: vdaas-ci <ci@vdaas.org>

vdaas-ci force-pushed the test/internal/add-newtest-for-errors-option branch from 1d41e30 to 566a9ea Compare February 1, 2021 22:46

github-actions bot added size/XL and removed size/XL labels Feb 1, 2021

kevindiu approved these changes Feb 2, 2021

View reviewed changes

kevindiu merged commit 956e00c into master Feb 2, 2021

kevindiu deleted the test/internal/add-newtest-for-errors-option branch February 2, 2021 02:06

vdaas-ci mentioned this pull request Feb 2, 2021

[major] v1.0.0 Release #974

Merged

11 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

create new test and refactor for errors/option #950

create new test and refactor for errors/option #950

vankichi commented Jan 25, 2021 •

edited

Loading

vdaas-ci commented Jan 25, 2021

codecov bot commented Jan 25, 2021 •

edited

Loading

hlts2 left a comment

hlts2 left a comment

vankichi commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu left a comment

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 2, 2021

vdaas-ci commented Feb 2, 2021

vdaas-ci commented Feb 2, 2021

create new test and refactor for errors/option #950

create new test and refactor for errors/option #950

Conversation

vankichi commented Jan 25, 2021 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Jan 25, 2021

codecov bot commented Jan 25, 2021 • edited Loading

Codecov Report

hlts2 left a comment

Choose a reason for hiding this comment

hlts2 left a comment

Choose a reason for hiding this comment

vankichi commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu left a comment

Choose a reason for hiding this comment

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

vdaas-ci commented Feb 1, 2021

kevindiu commented Feb 2, 2021

vdaas-ci commented Feb 2, 2021

vdaas-ci commented Feb 2, 2021

vankichi commented Jan 25, 2021 •

edited

Loading

codecov bot commented Jan 25, 2021 •

edited

Loading