-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for internal/errors/vald #958
Conversation
[CHATOPS:HELP] ChatOps commands.
|
internal/errors/vald_test.go
Outdated
type want struct { | ||
want error | ||
} | ||
type test struct{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
File is not gofmt
-ed with -s
(gofmt)
Codecov Report
@@ Coverage Diff @@
## master #958 +/- ##
=======================================
Coverage 15.18% 15.18%
=======================================
Files 493 492 -1
Lines 25683 25622 -61
=======================================
- Hits 3900 3891 -9
+ Misses 21533 21490 -43
+ Partials 250 241 -9
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thank you
LGTM
/format |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-vald |
Signed-off-by: vankichi <kyukawa315@gmail.com>
34b7bfe
to
ac1bb47
Compare
[FORMAT] Updating license headers and formatting go codes triggered by kevindiu. |
Signed-off-by: vdaas-ci <ci@vdaas.org>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
/format |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
Signed-off-by: vankichi kyukawa315@gmail.com
I created the test for
internal/errors/vald.go
and also added comments forinternl/errors/vald.go
.grammar check has passed.
Description:
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: