Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for internal/errors/vald #958

Merged
merged 4 commits into from
Feb 1, 2021

Conversation

vankichi
Copy link
Contributor

Signed-off-by: vankichi kyukawa315@gmail.com

I created the test for internal/errors/vald.go and also added comments for internl/errors/vald.go.
grammar check has passed.

Description:

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.7
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.13.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vdaas-ci
Copy link
Collaborator

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

type want struct {
want error
}
type test struct{
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚫 [golangci] reported by reviewdog 🐶
File is not gofmt-ed with -s (gofmt)

@codecov
Copy link

codecov bot commented Jan 27, 2021

Codecov Report

Merging #958 (8864ece) into master (f8abd67) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #958   +/-   ##
=======================================
  Coverage   15.18%   15.18%           
=======================================
  Files         493      492    -1     
  Lines       25683    25622   -61     
=======================================
- Hits         3900     3891    -9     
+ Misses      21533    21490   -43     
+ Partials      250      241    -9     
Impacted Files Coverage Δ
internal/errors/vald.go 100.00% <ø> (+100.00%) ⬆️
internal/net/net.go
internal/worker/worker.go 83.33% <0.00%> (+1.04%) ⬆️
internal/errgroup/group.go 93.93% <0.00%> (+1.51%) ⬆️
internal/errors/errors.go 37.50% <0.00%> (+1.56%) ⬆️
internal/db/storage/blob/s3/reader/reader.go 94.56% <0.00%> (+31.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 488dd4a...d1a0154. Read the comment docs.

hlts2
hlts2 previously approved these changes Jan 29, 2021
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you
LGTM

@kevindiu
Copy link
Contributor

/format
/rebase
/approve

kevindiu
kevindiu previously approved these changes Jan 29, 2021
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vdaas-ci
Copy link
Collaborator

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-vald

Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci vdaas-ci dismissed stale reviews from kevindiu and hlts2 via ac1bb47 January 29, 2021 04:42
@vdaas-ci vdaas-ci force-pushed the test/internal/add-newtest-for-errors-vald branch from 34b7bfe to ac1bb47 Compare January 29, 2021 04:42
@vdaas-ci
Copy link
Collaborator

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

internal/errors/vald_test.go Outdated Show resolved Hide resolved
internal/errors/vald_test.go Outdated Show resolved Hide resolved
internal/errors/vald_test.go Outdated Show resolved Hide resolved
vankichi and others added 2 commits January 29, 2021 13:53
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
Co-authored-by: Kevin Diu <kevindiujp@gmail.com>
@vankichi
Copy link
Contributor Author

vankichi commented Feb 1, 2021

/format

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 1, 2021

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@kevindiu kevindiu merged commit 7e1997a into master Feb 1, 2021
@kevindiu kevindiu deleted the test/internal/add-newtest-for-errors-vald branch February 1, 2021 09:43
@vdaas-ci vdaas-ci mentioned this pull request Feb 2, 2021
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants