Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add test for internal/errors/unit #979

Merged
merged 2 commits into from
Feb 8, 2021

Conversation

vankichi
Copy link
Contributor

@vankichi vankichi commented Feb 3, 2021

Signed-off-by: vankichi kyukawa315@gmail.com

Description:

I added the test for internal/errors/unit.go
grammar check has padded

Related Issue:

How Has This Been Tested?:

Environment:

  • Go Version: 1.15.7
  • Docker Version: 19.03.8
  • Kubernetes Version: 1.18.2
  • NGT Version: 1.13.1

Types of changes:

  • Bug fix [type/bug]
  • New feature [type/feature]
  • Add tests [type/test]
  • Security related changes [type/security]
  • Add documents [type/documentation]
  • Refactoring [type/refactoring]
  • Update dependencies [type/dependency]
  • Update benchmarks and performances [type/bench]
  • Update CI [type/ci]

Changes to Core Features:

  • Have you added an explanation of what your changes do and why you'd like us to include them?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully ran tests with your changes locally?

Checklist:

  • I have read the CONTRIBUTING document.
  • I have checked open Pull Requests for the similar feature or fixes?
  • I have added tests and benchmarks to cover my changes.
  • I have ensured all new and existing tests passed.
  • I have commented my code, particularly in hard-to-understand areas
  • I have updated the documentation accordingly.

@vankichi
Copy link
Contributor Author

vankichi commented Feb 3, 2021

/format

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 3, 2021

[CHATOPS:HELP] ChatOps commands.

  • 🙆‍♀️ /approve - approve
  • 💌 /changelog - add changelog comment
  • 🍱 /format - format codes and add licenses
  • /gen-test - generate test codes
  • 🏷️ /label - add labels
  • /rebase - rebase master
  • 🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 3, 2021

[FORMAT] Updating license headers and formatting go codes triggered by vankichi.

@codecov
Copy link

codecov bot commented Feb 3, 2021

Codecov Report

Merging #979 (7ef0b17) into master (9c8cace) will increase coverage by 0.10%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #979      +/-   ##
==========================================
+ Coverage   14.43%   14.53%   +0.10%     
==========================================
  Files         493      493              
  Lines       27967    27967              
==========================================
+ Hits         4036     4065      +29     
+ Misses      23684    23661      -23     
+ Partials      247      241       -6     
Impacted Files Coverage Δ
internal/errors/unit.go 100.00% <ø> (+100.00%) ⬆️
internal/worker/queue.go 95.00% <0.00%> (-5.00%) ⬇️
internal/worker/worker.go 82.29% <0.00%> (ø)
internal/file/watch/watch.go 91.00% <0.00%> (+1.00%) ⬆️
internal/db/storage/blob/s3/reader/reader.go 94.56% <0.00%> (+31.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f6ec4a2...7ef0b17. Read the comment docs.

hlts2
hlts2 previously approved these changes Feb 3, 2021
Copy link
Collaborator

@hlts2 hlts2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vankichi vankichi self-assigned this Feb 4, 2021
kevindiu
kevindiu previously approved these changes Feb 8, 2021
Copy link
Contributor

@kevindiu kevindiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kevindiu
Copy link
Contributor

kevindiu commented Feb 8, 2021

/rebase
/format
/approve

@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 8, 2021

[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-unit

vankichi and others added 2 commits February 8, 2021 04:51
Signed-off-by: vankichi <kyukawa315@gmail.com>
@vdaas-ci vdaas-ci dismissed stale reviews from kevindiu and hlts2 via 7ef0b17 February 8, 2021 04:51
@vdaas-ci vdaas-ci force-pushed the test/internal/add-newtest-for-errors-unit branch from ef18e7f to 7ef0b17 Compare February 8, 2021 04:51
@vdaas-ci
Copy link
Collaborator

vdaas-ci commented Feb 8, 2021

[FORMAT] Updating license headers and formatting go codes triggered by kevindiu.

Copy link
Collaborator

@vdaas-ci vdaas-ci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[APPROVED] This PR is approved by kevindiu.

@kevindiu kevindiu merged commit 6e80d7c into master Feb 8, 2021
@kevindiu kevindiu deleted the test/internal/add-newtest-for-errors-unit branch February 8, 2021 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants