-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add test for internal/errors/tensorflow #982
add test for internal/errors/tensorflow #982
Conversation
[CHATOPS:HELP] ChatOps commands.
|
internal/errors/tensorflow_test.go
Outdated
}, | ||
{ | ||
name: "return an ErrInputLength error when i and f is zero value", | ||
args: args{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
File is not gofmt
-ed with -s
(gofmt)
} | ||
}) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
File is not gofumpt
-ed (gofumpt)
} | ||
}) | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚫 [golangci] reported by reviewdog 🐶
File is not gofumpt
-ed (gofumpt)
/format |
[FORMAT] Updating license headers and formatting go codes triggered by vankichi. |
Codecov Report
@@ Coverage Diff @@
## master #982 +/- ##
==========================================
- Coverage 14.53% 14.46% -0.08%
==========================================
Files 493 493
Lines 27967 27967
==========================================
- Hits 4065 4045 -20
- Misses 23661 23676 +15
- Partials 241 246 +5
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-tensorflow |
6d27f35
to
b3878b0
Compare
[FORMAT] Updating license headers and formatting go codes triggered by kevindiu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by kevindiu.
/rebase |
[REBASE] Rebase triggered by kevindiu for branch: test/internal/add-newtest-for-errors-tensorflow |
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vdaas-ci <ci@vdaas.org>
Signed-off-by: vankichi <kyukawa315@gmail.com>
Signed-off-by: vankichi <kyukawa315@gmail.com>
b3878b0
to
887a61b
Compare
[FORMAT] Updating license headers and formatting go codes triggered by kevindiu. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
[APPROVED] This PR is approved by kevindiu.
Signed-off-by: vankichi kyukawa315@gmail.com
Wait for reply from @datelier
Description:
Added the test for
internal/errors/tensorflow.go
and the comment for each function.grammar check has passed.
Related Issue:
How Has This Been Tested?:
Environment:
Types of changes:
Changes to Core Features:
Checklist: