Remove base docker image #995

hlts2 · 2021-02-09T06:52:29Z

Description:

I deleted the base docker image and dependencies.

Related Issue:

How Has This Been Tested?:

Environment:

Go Version: 1.15.7
Docker Version: 19.03.8
Kubernetes Version: 1.18.2
NGT Version: 1.13.1

Types of changes:

Bug fix [type/bug]
New feature [type/feature]
Add tests [type/test]
Security related changes [type/security]
Add documents [type/documentation]
Refactoring [type/refactoring]
Update dependencies [type/dependency]
Update benchmarks and performances [type/bench]
Update CI [type/ci]

Changes to Core Features:

Have you added an explanation of what your changes do and why you'd like us to include them?
Have you written new tests for your core changes, as applicable?
Have you successfully ran tests with your changes locally?

Checklist:

I have read the CONTRIBUTING document.
I have checked open Pull Requests for the similar feature or fixes?
I have added tests and benchmarks to cover my changes.
I have ensured all new and existing tests passed.
I have commented my code, particularly in hard-to-understand areas
I have updated the documentation accordingly.

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

vdaas-ci · 2021-02-09T06:52:45Z

[CHATOPS:HELP] ChatOps commands.

🙆‍♀️ /approve - approve
💌 /changelog - add changelog comment
🍱 /format - format codes and add licenses
✅ /gen-test - generate test codes
🏷️ /label - add labels
⏪ /rebase - rebase master
🔚 2️⃣ 🔚 /label actions/e2e-deploy - run E2E deploy & integration test

github-actions

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

hadolint

dockers/meta/redis/Dockerfile|34 col 1| Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>
dockers/meta/redis/Dockerfile|40 col 1| Double quote to prevent globbing and word splitting.
dockers/tools/cli/loadtest/Dockerfile|37 col 1| Double quote to prevent globbing and word splitting.

github-actions · 2021-02-09T06:52:52Z

dockers/agent/core/ngt/Dockerfile

 ENV ORG vdaas
 ENV REPO vald
 ENV PKG agent/core/ngt
 ENV PKG_INTERNAL agent/internal
 ENV APP_NAME ngt

+RUN apt-get update && apt-get install -y --no-install-recommends \


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2021-02-09T06:52:52Z

dockers/agent/sidecar/Dockerfile

 ENV ORG vdaas
 ENV REPO vald
 ENV PKG agent/sidecar
 ENV PKG_INTERNAL agent/internal
 ENV APP_NAME sidecar

-COPY --from=golang /usr/local/go $GOROOT
+RUN apt-get update && apt-get install -y --no-install-recommends \


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2021-02-09T06:52:52Z

dockers/agent/sidecar/Dockerfile

+    && apt-get clean \
+    && rm -rf /var/lib/apt/lists/*
+
+RUN mkdir -p $GOPATH/src


📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

github-actions · 2021-02-09T06:52:52Z

dockers/dev/Dockerfile

-ARG YQ_VERSION=4.3.2
+ARG YQ_VERSION=4.5.0
+
+RUN apt-get update && apt-get install -y --no-install-recommends \


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2021-02-09T06:52:52Z

dockers/discoverer/k8s/Dockerfile

 ENV ORG vdaas
 ENV REPO vald
 ENV PKG discoverer/k8s
 ENV APP_NAME discoverer

-COPY --from=golang /usr/local/go $GOROOT
+RUN apt-get update && apt-get install -y --no-install-recommends \


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2021-02-09T06:52:55Z

dockers/manager/replication/agent/Dockerfile

+    && apt-get clean \
+    && rm -rf /var/lib/apt/lists/*
+
+RUN mkdir -p $GOPATH/src


📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

github-actions · 2021-02-09T06:52:55Z

dockers/manager/replication/controller/Dockerfile

 ENV ORG vdaas
 ENV REPO vald
 ENV PKG manager/replication/controller
 ENV APP_NAME controller

+RUN apt-get update && apt-get install -y --no-install-recommends \


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2021-02-09T06:52:55Z

dockers/manager/replication/controller/Dockerfile

+    && apt-get clean \
+    && rm -rf /var/lib/apt/lists/*
+
+RUN mkdir -p $GOPATH/src


📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

github-actions · 2021-02-09T06:52:55Z

dockers/meta/cassandra/Dockerfile

 ENV ORG vdaas
 ENV REPO vald
 ENV PKG meta/cassandra
 ENV APP_NAME meta

-COPY --from=golang /usr/local/go $GOROOT
+RUN apt-get update && apt-get install -y --no-install-recommends \


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2021-02-09T06:52:55Z

dockers/meta/cassandra/Dockerfile

+    && apt-get clean \
+    && rm -rf /var/lib/apt/lists/*
+
+RUN mkdir -p $GOPATH/src


📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

rinx

Sorry, maybe go.mod and go.sum are missing in dockers/ci/base/Dockerfile
https://github.com/vdaas/vald/pull/995/checks?check_run_id=1861034923

dockers/dev/Dockerfile

Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>

github-actions · 2021-02-09T08:57:58Z

dockers/meta/redis/Dockerfile

 ENV ORG vdaas
 ENV REPO vald
 ENV PKG meta/redis
 ENV APP_NAME meta

-COPY --from=golang /usr/local/go $GOROOT
+RUN apt-get update && apt-get install -y --no-install-recommends \


⚠️ [hadolint] <DL3008> _{reported by reviewdog 🐶}
Pin versions in apt get install. Instead of apt-get install <package> use apt-get install <package>=<version>

github-actions · 2021-02-09T08:57:58Z

dockers/meta/redis/Dockerfile

+    && apt-get clean \
+    && rm -rf /var/lib/apt/lists/*
+
+RUN mkdir -p $GOPATH/src


📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

github-actions · 2021-02-09T08:57:58Z

dockers/tools/cli/loadtest/Dockerfile

    libhdf5-dev \
    && ldconfig \
    && apt-get clean \
    && rm -rf /var/lib/apt/lists/*

+RUN mkdir -p $GOPATH/src


📝 [hadolint] <SC2086> _{reported by reviewdog 🐶}
Double quote to prevent globbing and word splitting.

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

…om/vdaas/vald into ci/docker/remove_base_docker_image

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

rinx · 2021-02-09T09:18:34Z

Thanks, great job 👍

kpango

LGTM

hlts2 added 5 commits February 9, 2021 15:17

fix: remove base image dependencies from several image

b0c83c3

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: remove base image dependencies and remove base image

61ded7b

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: remove base build workflow from github actions

b87222f

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: remove base image build task from makefile

265bbbd

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

fix: remove base image dependencies from deepsource

498e4e9

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

github-actions bot added area/makefile team/sre SRE team type/ci labels Feb 9, 2021

github-actions bot reviewed Feb 9, 2021

View reviewed changes

github-actions bot added priority/low size/S labels Feb 9, 2021

rinx reviewed Feb 9, 2021

View reviewed changes

dockers/dev/Dockerfile Show resolved Hide resolved

Update dockers/dev/Dockerfile

d96f660

Co-authored-by: Rintaro Okamura <rintaro.okamura@gmail.com>

github-actions bot added the size/L label Feb 9, 2021

github-actions bot reviewed Feb 9, 2021

View reviewed changes

github-actions bot removed the size/S label Feb 9, 2021

hlts2 added 3 commits February 9, 2021 17:59

fix: build fails for ci container. so I added go.mod and go.sum

91cbf62

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

Merge branch 'ci/docker/remove_base_docker_image' of https://github.c…

9b38ac3

…om/vdaas/vald into ci/docker/remove_base_docker_image

fix: set WORKDIR via variable

4f872d9

Signed-off-by: hlts2 <hiroto.funakoshi.hiroto@gmail.com>

rinx approved these changes Feb 9, 2021

View reviewed changes

kpango approved these changes Feb 9, 2021

View reviewed changes

kpango merged commit ca55ac1 into master Feb 9, 2021

kpango deleted the ci/docker/remove_base_docker_image branch February 9, 2021 09:32

This was referenced Feb 9, 2021

[patch] Bug fix on StreamGetObject API and DNS cache expiration / refactor net connection #986

Merged

[patch] v1.0.2 Release #998

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove base docker image #995

Remove base docker image #995

hlts2 commented Feb 9, 2021 •

edited

Loading

vdaas-ci commented Feb 9, 2021

github-actions bot left a comment

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

rinx left a comment

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

github-actions bot Feb 9, 2021

rinx commented Feb 9, 2021

kpango left a comment

Remove base docker image #995

Remove base docker image #995

Conversation

hlts2 commented Feb 9, 2021 • edited Loading

Description:

Related Issue:

How Has This Been Tested?:

Environment:

Types of changes:

Changes to Core Features:

Checklist:

vdaas-ci commented Feb 9, 2021

github-actions bot left a comment

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

rinx left a comment

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

github-actions bot Feb 9, 2021

Choose a reason for hiding this comment

rinx commented Feb 9, 2021

kpango left a comment

Choose a reason for hiding this comment

hlts2 commented Feb 9, 2021 •

edited

Loading