Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix iOS output #4

Merged
merged 8 commits into from
Feb 17, 2023
Merged

Fix iOS output #4

merged 8 commits into from
Feb 17, 2023

Conversation

germain-gg
Copy link
Contributor

@germain-gg germain-gg commented Feb 14, 2023

Fixes element-hq/compound#27
Follow up of #2

One for @pixlwave to keep an eye on.

Here are a few outstanding questions:

  • How to deal with the "references", can we do math on CGFloat ?
  • How to deal with the composition tokens
  • Letter spacing?
  • What tokens should be consumed directly ?

@janogarcia
Copy link
Contributor

janogarcia commented Feb 14, 2023

How to deal with the composition tokens

Not sure how exactly we should handle those in Style Dictionary (or if we need to do it at all) but if you are referring to typography composition tokens, I guess iOS engineers will be more interested in how those map to built-in text styles.

For example, font.body.lg.regular in Tokens Studio would match the builtin Body text style.

Letter spacing?

They don't need to use/consume it independently on iOS, it's part of the built-in text styles.

What tokens should be consumed directly ?

Other than the mapping explained above for composition tokens, the may be interested in what modifiers we use for built-in text styles (e.g., bold, tight leading). But I'm not sure if that's how they're approaching it.

See the "Modify the built-in text styles if necessary" subsection in Apple HIG Typography docs.

Copy link
Contributor

@janogarcia janogarcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See remarks in previous comment.

@germain-gg germain-gg merged commit beba4b0 into develop Feb 17, 2023
@germain-gg germain-gg deleted the gsouquet/ios-output branch February 17, 2023 10:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants